- Asa-dev - op-lists.linaro.org

Re: [Asa-dev] GICv3 ITS code repo for review

by shashi.mallela＠linaro.org

was trying qemu build with --enable-debug and hence the warnings were suppressed. Have resolved the warning now and updated the git repository. Also please find attached the overall patch file for reference. Thanks Shashi On Tue, 2021-03-02 at 20:31 +0000, Marcin Juszkiewicz via Asa-dev wrote: > W dniu 02.03.2021 o 21:07, Shashi Mallela via Asa-dev pisze: > > Hi All, > > > > As discussed in the meeting today,please find my ITS code > > implementation from linaro git repo below > > ssh://git@git.linaro.org/people/shashi.mallela/qemu.git > > Next time clone upstream, branch, do your job, push. > > "I wrote QEMU on one day" like commits are very bad signs. > > > Please provide your review comments. > > Build on x86-64 failed: > > $ ./configure --target-list=aarch64-softmmu > $ make -j12 > > FAILED: libcommon.fa.p/hw_intc_arm_gicv3_its.c.o > cc -Ilibcommon.fa.p -I. -I.. -I../capstone/include/capstone > -I../slirp > -I../slirp/src -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/glib- > 2.0 > -I/usr/lib64/glib-2.0/include -I/usr/include/libmount > -I/usr/include/blkid -I/usr/include/gio-unix-2.0 > -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/SDL2 > -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 > -I/usr/include/harfbuzz > -I/usr/include/freetype2 -I/usr/include/fribidi > -I/usr/include/libxml2 > -I/usr/include/cairo -I/usr/include/pixman-1 > -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 > -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 > -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 > -I/usr/include/libusb-1.0 -fdiagnostics-color=auto -pipe -Wall > -Winvalid-pch -Werror -std=gnu99 -O2 -g -isystem > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/linux-headers -isystem > linux-headers -iquote . -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/include -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/disas/libvixl -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/tcg/i386 -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/accel/tcg -pthread > -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -m64 -mcx16 -D_GNU_SOURCE > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes > -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes > -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration > -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k > -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs > -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 > -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi > -fstack-protector-strong -fPIC -DSTRUCT_IOVEC_DEFINED -D_REENTRANT > -Wno-undef -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -DNCURSES_WIDECHAR > -MD > -MQ libcommon.fa.p/hw_intc_arm_gicv3_its.c.o -MF > libcommon.fa.p/hw_intc_arm_gicv3_its.c.o.d -o > libcommon.fa.p/hw_intc_arm_gicv3_its.c.o -c > ../hw/intc/arm_gicv3_its.c > ../hw/intc/arm_gicv3_its.c: In function ‘process_int.isra’: > ../hw/intc/arm_gicv3_its.c:92:17: error: ‘icid’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] > 92 | l2t_id = icid / (page_sz / L1TABLE_ENTRY_SIZE); > | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../hw/intc/arm_gicv3_its.c:255:11: note: ‘icid’ was declared here > 255 | uint16_t icid; > | ^~~~ > cc1: all warnings being treated as errors >

3 years, 2 months

1
0
0 0

Re: [Asa-dev] GICv3 ITS code repo for review

by shashi.mallela＠linaro.org

This was intended to be a code review share primarily,though i did not see the build error at my end. Will update. Thanks Shashi On Tue, 2021-03-02 at 20:31 +0000, Marcin Juszkiewicz via Asa-dev wrote: > W dniu 02.03.2021 o 21:07, Shashi Mallela via Asa-dev pisze: > > Hi All, > > > > As discussed in the meeting today,please find my ITS code > > implementation from linaro git repo below > > ssh://git@git.linaro.org/people/shashi.mallela/qemu.git > > Next time clone upstream, branch, do your job, push. > > "I wrote QEMU on one day" like commits are very bad signs. > > > Please provide your review comments. > > Build on x86-64 failed: > > $ ./configure --target-list=aarch64-softmmu > $ make -j12 > > FAILED: libcommon.fa.p/hw_intc_arm_gicv3_its.c.o > cc -Ilibcommon.fa.p -I. -I.. -I../capstone/include/capstone > -I../slirp > -I../slirp/src -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/glib- > 2.0 > -I/usr/lib64/glib-2.0/include -I/usr/include/libmount > -I/usr/include/blkid -I/usr/include/gio-unix-2.0 > -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/SDL2 > -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 > -I/usr/include/harfbuzz > -I/usr/include/freetype2 -I/usr/include/fribidi > -I/usr/include/libxml2 > -I/usr/include/cairo -I/usr/include/pixman-1 > -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 > -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 > -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 > -I/usr/include/libusb-1.0 -fdiagnostics-color=auto -pipe -Wall > -Winvalid-pch -Werror -std=gnu99 -O2 -g -isystem > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/linux-headers -isystem > linux-headers -iquote . -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/include -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/disas/libvixl -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/tcg/i386 -iquote > /home/hrw/devel/linaro/sbsa-qemu/code/qemu/accel/tcg -pthread > -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -m64 -mcx16 -D_GNU_SOURCE > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes > -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes > -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration > -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k > -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs > -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 > -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi > -fstack-protector-strong -fPIC -DSTRUCT_IOVEC_DEFINED -D_REENTRANT > -Wno-undef -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -DNCURSES_WIDECHAR > -MD > -MQ libcommon.fa.p/hw_intc_arm_gicv3_its.c.o -MF > libcommon.fa.p/hw_intc_arm_gicv3_its.c.o.d -o > libcommon.fa.p/hw_intc_arm_gicv3_its.c.o -c > ../hw/intc/arm_gicv3_its.c > ../hw/intc/arm_gicv3_its.c: In function ‘process_int.isra’: > ../hw/intc/arm_gicv3_its.c:92:17: error: ‘icid’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] > 92 | l2t_id = icid / (page_sz / L1TABLE_ENTRY_SIZE); > | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../hw/intc/arm_gicv3_its.c:255:11: note: ‘icid’ was declared here > 255 | uint16_t icid; > | ^~~~ > cc1: all warnings being treated as errors >

3 years, 2 months

1
0
0 0

Re: [Asa-dev] GICv3 ITS code repo for review

by Marcin Juszkiewicz

W dniu 02.03.2021 o 21:07, Shashi Mallela via Asa-dev pisze: > Hi All, > > As discussed in the meeting today,please find my ITS code implementation from linaro git repo below > ssh://git@git.linaro.org/people/shashi.mallela/qemu.git Next time clone upstream, branch, do your job, push. "I wrote QEMU on one day" like commits are very bad signs. > Please provide your review comments. Build on x86-64 failed: $ ./configure --target-list=aarch64-softmmu $ make -j12 FAILED: libcommon.fa.p/hw_intc_arm_gicv3_its.c.o cc -Ilibcommon.fa.p -I. -I.. -I../capstone/include/capstone -I../slirp -I../slirp/src -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/SDL2 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/libxml2 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/libusb-1.0 -fdiagnostics-color=auto -pipe -Wall -Winvalid-pch -Werror -std=gnu99 -O2 -g -isystem /home/hrw/devel/linaro/sbsa-qemu/code/qemu/linux-headers -isystem linux-headers -iquote . -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu/include -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu/disas/libvixl -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu/tcg/i386 -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu/accel/tcg -pthread -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIC -DSTRUCT_IOVEC_DEFINED -D_REENTRANT -Wno-undef -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -DNCURSES_WIDECHAR -MD -MQ libcommon.fa.p/hw_intc_arm_gicv3_its.c.o -MF libcommon.fa.p/hw_intc_arm_gicv3_its.c.o.d -o libcommon.fa.p/hw_intc_arm_gicv3_its.c.o -c ../hw/intc/arm_gicv3_its.c ../hw/intc/arm_gicv3_its.c: In function ‘process_int.isra’: ../hw/intc/arm_gicv3_its.c:92:17: error: ‘icid’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 92 | l2t_id = icid / (page_sz / L1TABLE_ENTRY_SIZE); | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../hw/intc/arm_gicv3_its.c:255:11: note: ‘icid’ was declared here 255 | uint16_t icid; | ^~~~ cc1: all warnings being treated as errors

3 years, 2 months

1
0
0 0

GICv3 ITS code repo for review

by Shashi Mallela

Hi All, As discussed in the meeting today,please find my ITS code implementation from linaro git repo below ssh://git@git.linaro.org/people/shashi.mallela/qemu.git Please provide your review comments. While majority of the functionality is implemented,there are final changes to be done around GITS_TRANSLATER and referencing the ITS device into sbsa-ref which i shall update subsequently. Thanks Shashi

3 years, 2 months

1
0
0 0

Re: [Asa-dev] Insanely long time for each PE test in sbsa-acs

by Leif Lindholm

On Tue, Mar 02, 2021 at 11:18:31 +0000, Leif Lindholm via Asa-dev wrote: > On Tue, Mar 02, 2021 at 11:02:35 +0000, Marcin Juszkiewicz via Asa-dev wrote: > > I run sbsa-acs in both QEMU and on HoneyComb to check how it goes. > > > > Recently I noticed long times of PE checks. For example "2 : Check for SIMD > > extensions" is running here for over 3 minutes. On machine with 4 emulated > > cpu cores (a72). > > That sounds completely bonkers. > https://github.com/ARM-software/sbsa-acs/blob/master/test_pool/pe/test_c002… > > I mean the actual test here is reading ID_AA64PFR0_EL1 and checking > the value of a field in the result. > > > That's with local git HEAD builds of QEMU, EDK2, Sbsa.efi using Fedora > > 10.2.1 cross compiler. > > > > Any ideas what is going on? > > 1) The test itself is not the problem. > 2) Masahisa has reported other weirdness recently wrt MPIDR values in > ACPI and stuff. > > What do you get reported in the logs for number of PEs in system and > such? We carried the conversation over to IRC, and the investigation resulted in https://edk2.groups.io/g/devel/topic/patch_edk2_platforms_1_1/81024935 / Leif

3 years, 2 months

1
0
0 0

Re: [Asa-dev] Insanely long time for each PE test in sbsa-acs

by Leif Lindholm

On Tue, Mar 02, 2021 at 11:02:35 +0000, Marcin Juszkiewicz via Asa-dev wrote: > I run sbsa-acs in both QEMU and on HoneyComb to check how it goes. > > Recently I noticed long times of PE checks. For example "2 : Check for SIMD > extensions" is running here for over 3 minutes. On machine with 4 emulated > cpu cores (a72). That sounds completely bonkers. https://github.com/ARM-software/sbsa-acs/blob/master/test_pool/pe/test_c002… I mean the actual test here is reading ID_AA64PFR0_EL1 and checking the value of a field in the result. > That's with local git HEAD builds of QEMU, EDK2, Sbsa.efi using Fedora > 10.2.1 cross compiler. > > Any ideas what is going on? 1) The test itself is not the problem. 2) Masahisa has reported other weirdness recently wrt MPIDR values in ACPI and stuff. What do you get reported in the logs for number of PEs in system and such? / Leif

3 years, 2 months

1
0
0 0

Insanely long time for each PE test in sbsa-acs

by Marcin Juszkiewicz

I run sbsa-acs in both QEMU and on HoneyComb to check how it goes. Recently I noticed long times of PE checks. For example "2 : Check for SIMD extensions" is running here for over 3 minutes. On machine with 4 emulated cpu cores (a72). That's with local git HEAD builds of QEMU, EDK2, Sbsa.efi using Fedora 10.2.1 cross compiler. Any ideas what is going on?

3 years, 2 months

1
0
0 0

SynchronousException occurs in secondary core while booting edk2

by Masahisa Kojima

Hi All, Sorry for long email, but I need your advice to debug my current problem. [Issue] SynchronousExceptionSPx() occurs in secondary core while primary core is executing to boot edk2. # I use almost latest TF-A and edk2 source code. # TF-A Includes Graeme's patches to support 512 cores. [Detail] In sbsa-qemu boot flow, primary core starts bl1 -> bl2 -> bl31 -> bl32 -> edk2. My sbsa-qemu enables UEFI secure variables, so edk2 calls MM_COMMUNICATE service and access uefi variables using StandaloneMM variable/flash drivers running in Secure-EL0. For secondary cores, all secondary cores sleep with wfe() in plat/qemu/common/aarch64/plat_helpers.S::plat_secondary_cold_boot_setup() in bl1, until linux kernel calls PSCI(cpu on). The below gdb output is at edk2 boot. At this point, everythig is fine and edk2 <-> StandaloneMM communication works. --- (gdb) info thread Id Target Id Frame * 1 Thread 1.1 (CPU#0 [running]) spm_mm_smc_handler (smc_fid=3288334433, x1=0, x2=0, x3=0, x4=0, cookie=0x0 <bl1_entrypoint>, handle=0x3ff8a010 <sp_ctx+16>, flags=0) at services/std_svc/spm_mm/spm_mm_main.c:280 2 Thread 1.2 (CPU#1 [running]) plat_secondary_cold_boot_setup () at plat/qemu/common/aarch64/plat_helpers.S:84 --- Several MM_COMMUNICATE service call occurs in edk2, suddenly SynchronousExceptionSPx() is invoked in secondary core. (To make issue simple, I start qemu with "-smp 2") # I set breakpoint at SynchronousExceptionSPx() in secondary core. --- (gdb) info thread Id Target Id Frame 1 Thread 1.1 (CPU#0 [running]) 0x0000000020aef988 in ?? () * 2 Thread 1.2 (CPU#1 [running]) SynchronousExceptionSPx () at bl1/aarch64/bl1_exceptions.S:54 --- After that, secondary core goes into panic_handler() and could not boot anymore. EDK2 and standaloneMM runs only on primary core until linux issues PSCI call, so I don't have any idea why SynchronousException(generated by software?) occurs in secondary core. [Observation] 1) Some EL3 registers are as follows when secondary core stops with breakpoint at SynchronousExceptionSPx (). ELR_EL3 0x31c4 ESR_EL3 0x2000000 FAR_EL3 0x0 ELR_EL3 points 0x31c4, it is wfe() at plat_secondary_cold_boot_setup(). Does it mean SynchronousException occurs while secondary core sleep with wfe()? # All register dump and disassembled bl1.elf are attached. 2) PSCI related area "PLAT_QEMU_HOLD_BASE"(starts from bottom of the secure SRAM(0x20000000)) is as expected. Secondary core#1 checks 0x20000010 in poll_mailbox() loop, the value(0) means secondary core shall keep to sleep with wfe(). --- INFO: 0x20000000 3fcee114 INFO: 0x20000008 0 INFO: 0x20000010 0 INFO: 0x20000018 0 --- This log is output in every spm_mm SMC handler of primary core. 3) When I load same TF-A/BL32(StandaloneMM) image and disable UEFI secure boot on edk2, this issue does not occur. It means calling MM_COMMUNICATE service causes this issue. Does anyone have any idea/clue to debug of this issue? Thanks, Masahisa

3 years, 2 months

2
2
0 0

SMP boot fails

by Masahisa Kojima

Hi All, I just encounter this error, I would like to share the information. SMP boot fails with the latest master branch of edk2/edk2-platforms/tf-a as of today. # I boot sbsa-qemu with "-smp 4". Linux kernel outputs following error. [ 0.000000] duplicate boot CPU MPIDR: 0x0 in MADT [ 0.000000] duplicate boot CPU MPIDR: 0x0 in MADT [ 0.000000] duplicate boot CPU MPIDR: 0x0 in MADT debian@debian:~$ lscpu Architecture: aarch64 Byte Order: Little Endian CPU(s): 1 On-line CPU(s) list: 0 Thread(s) per core: 1 Core(s) per socket: 1 Socket(s): 1 NUMA node(s): 1 Vendor ID: ARM Model: 3 Model name: Cortex-A72 Stepping: r0p3 BogoMIPS: 125.00 L1d cache: 32K L1i cache: 32K L2 cache: 512K NUMA node0 CPU(s): 0 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 cpuid Thanks, Masahisa

3 years, 2 months

1
0
0 0

SBSA level 3,4 cards

by Marcin Juszkiewicz

During today's meeting we agreed on creating Jira cards to track how close we are to SBSA level 3 and 4 compliance when it comes to QEMU SBSA Reference Platform. SBSA level 3 requirements are tracked in card ASA-75. I marked several cards as blockers of it. SBSA level 4 is tracked in ASA-76. It depends on ASA-75 and then has several newer cards added as blockers: ASA-81 Pass "Memory Access to Un-Populated addr" test in SBSA-ACS ASA-80 Pass PCIe tests in SBSA-ACS ASA-79 Pass PCIe MSI/MSI-X test in SBSA-ACS ASA-78 Pass VMID16 test in SBSA-ACS ASA-77 Pass RAS test in SBSA-ACS ASA-74 Add support for newer cpu core than Cortex-A72 ASA-67 Add Virtual Host Extensions (VHE) Each card got failure message from SBSA-ACS as first comment. ASA-74 among with QEMU-414 will bring us Cortex-A76 which will be v8.2 so we should pass most of PE tests. According to SBSA v6.1 specification we will need ARMv8.3 cpu for level 4 (level 3 is fine with v8.0 one). This will be sorted out once we get v8.2 one.

3 years, 4 months

1
0
0 0

2024

2023

2022

2021

2020

Asa-dev