This was intended to be a code review share primarily,though i did not see the build error at my end. Will update.

Thanks Shashi

On Tue, 2021-03-02 at 20:31 +0000, Marcin Juszkiewicz via Asa-dev wrote:

W dniu 02.03.2021 o 21:07, Shashi Mallela via Asa-dev pisze:

...

Hi All,

As discussed in the meeting today,please find my ITS code implementation from linaro git repo below ssh://git@git.linaro.org/people/shashi.mallela/qemu.git

Next time clone upstream, branch, do your job, push.

"I wrote QEMU on one day" like commits are very bad signs.

...

Please provide your review comments.

Build on x86-64 failed:

$ ./configure --target-list=aarch64-softmmu $ make -j12

FAILED: libcommon.fa.p/hw_intc_arm_gicv3_its.c.o cc -Ilibcommon.fa.p -I. -I.. -I../capstone/include/capstone -I../slirp -I../slirp/src -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/glib- 2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/SDL2 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/libxml2 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/libusb-1.0 -fdiagnostics-color=auto -pipe -Wall -Winvalid-pch -Werror -std=gnu99 -O2 -g -isystem /home/hrw/devel/linaro/sbsa-qemu/code/qemu/linux-headers -isystem linux-headers -iquote . -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu/include -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu/disas/libvixl -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu/tcg/i386 -iquote /home/hrw/devel/linaro/sbsa-qemu/code/qemu/accel/tcg -pthread -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIC -DSTRUCT_IOVEC_DEFINED -D_REENTRANT -Wno-undef -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -DNCURSES_WIDECHAR -MD -MQ libcommon.fa.p/hw_intc_arm_gicv3_its.c.o -MF libcommon.fa.p/hw_intc_arm_gicv3_its.c.o.d -o libcommon.fa.p/hw_intc_arm_gicv3_its.c.o -c ../hw/intc/arm_gicv3_its.c ../hw/intc/arm_gicv3_its.c: In function ‘process_int.isra’: ../hw/intc/arm_gicv3_its.c:92:17: error: ‘icid’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 92 | l2t_id = icid / (page_sz / L1TABLE_ENTRY_SIZE); | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../hw/intc/arm_gicv3_its.c:255:11: note: ‘icid’ was declared here 255 | uint16_t icid; | ^~~~ cc1: all warnings being treated as errors