Hi all,
in the meeting held today we decided to go ahead as follows in relation to ARM64 virt CPU hotplug patches and QEmu changes:
- James requires QEmu changes to test his branch[1] - Huawei (Salil) agreed to upgrade the QEmu patches to the latest ACPI specs (and James' code [1]) - QEmu updates will be given with a branch/link in reply to this email thread so that James can complete [1] testing against them - Any testing, bug report, communication will take place through this mailing list before public posting on a kernel ML, so please keep an eye on this thread if you'd like to collaborate/help - It would be good to get some feedback from containers/kubernetes developers on the full software stack - after all we are making these changes to enable the ecosystem
Please chime in if I forgot something or reach out, all comments are welcome.
Lorenzo
[1] https://gitlab.arm.com/linux-arm/linux-jm/-/tree/virtual_cpu_hotplug/rfc/v0
Hi Lorenzo & Everyone, Many thanks. I have picked this up and doing the review and testing now and will soon get back to you with initial results with this new branch.
Many thanks Salil
-----Original Message----- From: Lorenzo Pieralisi via Linaro-open-discussions [mailto:linaro-open-discussions@op-lists.linaro.org] Sent: Tuesday, August 23, 2022 4:10 PM To: linaro-open-discussions@op-lists.linaro.org Cc: James Morse james.morse@arm.com Subject: [Linaro-open-discussions] ARM64 virt CPU HP - plan
Hi all,
in the meeting held today we decided to go ahead as follows in relation to ARM64 virt CPU hotplug patches and QEmu changes:
- James requires QEmu changes to test his branch[1]
- Huawei (Salil) agreed to upgrade the QEmu patches to the latest ACPI specs (and James' code [1])
- QEmu updates will be given with a branch/link in reply to this email thread so that James can complete [1] testing against them
- Any testing, bug report, communication will take place through this mailing list before public posting on a kernel ML, so please keep an eye on this thread if you'd like to collaborate/help
- It would be good to get some feedback from containers/kubernetes developers on the full software stack - after all we are making these changes to enable the ecosystem
Please chime in if I forgot something or reach out, all comments are welcome.
Lorenzo
[1] https://gitlab.arm.com/linux-arm/linux-jm/-/tree/virtual_cpu_hotplug/rfc/v0 -- Linaro-open-discussions mailing list -- linaro-open-discussions@op-lists.linaro.org https://collaborate.linaro.org/display/LOD/Linaro+Open+Discussions+Home
Hi James, For the discussion, would it be possible to post the patches shared in the repository on the Linaro mailing list?
https://gitlab.arm.com/linux-arm/linux-jm/-/tree/virtual_cpu_hotplug/rfc/v0
Thanks Salil Mehta
-----Original Message----- From: Salil Mehta Sent: Wednesday, August 24, 2022 8:58 AM To: 'Lorenzo Pieralisi' lorenzo.pieralisi@linaro.org; linaro-open-discussions@op-lists.linaro.org Cc: James Morse james.morse@arm.com Subject: RE: [Linaro-open-discussions] ARM64 virt CPU HP - plan
Hi Lorenzo & Everyone, Many thanks. I have picked this up and doing the review and testing now and will soon get back to you with initial results with this new branch.
Many thanks Salil
-----Original Message----- From: Lorenzo Pieralisi via Linaro-open-discussions [mailto:linaro-open-discussions@op-lists.linaro.org] Sent: Tuesday, August 23, 2022 4:10 PM To: linaro-open-discussions@op-lists.linaro.org Cc: James Morse james.morse@arm.com Subject: [Linaro-open-discussions] ARM64 virt CPU HP - plan
Hi all,
in the meeting held today we decided to go ahead as follows in relation to ARM64 virt CPU hotplug patches and QEmu changes:
- James requires QEmu changes to test his branch[1]
- Huawei (Salil) agreed to upgrade the QEmu patches to the latest ACPI specs (and James' code [1])
- QEmu updates will be given with a branch/link in reply to this email thread so that James can complete [1] testing against them
- Any testing, bug report, communication will take place through this mailing list before public posting on a kernel ML, so please keep an eye on this thread if you'd like to collaborate/help
- It would be good to get some feedback from containers/kubernetes developers on the full software stack - after all we are making these changes to enable the ecosystem
Please chime in if I forgot something or reach out, all comments are welcome.
Lorenzo
[1]
https://gitlab.arm.com/linux-arm/linux-jm/-/tree/virtual_cpu_hotplug/rfc/v0
-- Linaro-open-discussions mailing list -- linaro-open-discussions@op-lists.linaro.org https://collaborate.linaro.org/display/LOD/Linaro+Open+Discussions+Home
Hi Salil,
Which one is the linaro mailing list? This one?
Thanks,
James
On 24/08/2022 16:33, Salil Mehta wrote:
Hi James, For the discussion, would it be possible to post the patches shared in the repository on the Linaro mailing list?
https://gitlab.arm.com/linux-arm/linux-jm/-/tree/virtual_cpu_hotplug/rfc/v0
Thanks Salil Mehta
-----Original Message----- From: Salil Mehta Sent: Wednesday, August 24, 2022 8:58 AM To: 'Lorenzo Pieralisi' lorenzo.pieralisi@linaro.org; linaro-open-discussions@op-lists.linaro.org Cc: James Morse james.morse@arm.com Subject: RE: [Linaro-open-discussions] ARM64 virt CPU HP - plan
Hi Lorenzo & Everyone, Many thanks. I have picked this up and doing the review and testing now and will soon get back to you with initial results with this new branch.
Many thanks Salil
-----Original Message----- From: Lorenzo Pieralisi via Linaro-open-discussions [mailto:linaro-open-discussions@op-lists.linaro.org] Sent: Tuesday, August 23, 2022 4:10 PM To: linaro-open-discussions@op-lists.linaro.org Cc: James Morse james.morse@arm.com Subject: [Linaro-open-discussions] ARM64 virt CPU HP - plan
Hi all,
in the meeting held today we decided to go ahead as follows in relation to ARM64 virt CPU hotplug patches and QEmu changes:
- James requires QEmu changes to test his branch[1]
- Huawei (Salil) agreed to upgrade the QEmu patches to the latest ACPI specs (and James' code [1])
- QEmu updates will be given with a branch/link in reply to this email thread so that James can complete [1] testing against them
- Any testing, bug report, communication will take place through this mailing list before public posting on a kernel ML, so please keep an eye on this thread if you'd like to collaborate/help
- It would be good to get some feedback from containers/kubernetes developers on the full software stack - after all we are making these changes to enable the ecosystem
Please chime in if I forgot something or reach out, all comments are welcome.
Lorenzo
[1]
https://gitlab.arm.com/linux-arm/linux-jm/-/tree/virtual_cpu_hotplug/rfc/v0
-- Linaro-open-discussions mailing list -- linaro-open-discussions@op-lists.linaro.org https://collaborate.linaro.org/display/LOD/Linaro+Open+Discussions+Home
Hi James, I suppose this is where Jean-Phillipe floated his PSCI patches[1] initially last year before eventually sending it publicly[2]?
I can see some people commenting there on the patches :)
Thanks Salil
References: [1] https://op-lists.linaro.org/archives/list/linaro-open-discussions@op-lists.l... [2] https://lore.kernel.org/kvmarm/20210608154805.216869-1-jean-philippe@linaro....
-----Original Message----- From: James Morse [mailto:james.morse@arm.com] Sent: Thursday, August 25, 2022 3:23 PM To: Salil Mehta salil.mehta@huawei.com; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org; linaro-open-discussions@op-lists.linaro.org Subject: Re: [Linaro-open-discussions] ARM64 virt CPU HP - plan
Hi Salil,
Which one is the linaro mailing list? This one?
Thanks,
James
On 24/08/2022 16:33, Salil Mehta wrote:
Hi James, For the discussion, would it be possible to post the patches shared in the
repository on the Linaro mailing list?
https://gitlab.arm.com/linux-arm/linux-jm/-/tree/virtual_cpu_hotplug/rfc/v0
Thanks Salil Mehta
-----Original Message----- From: Salil Mehta Sent: Wednesday, August 24, 2022 8:58 AM To: 'Lorenzo Pieralisi' lorenzo.pieralisi@linaro.org; linaro-open-discussions@op-lists.linaro.org Cc: James Morse james.morse@arm.com Subject: RE: [Linaro-open-discussions] ARM64 virt CPU HP - plan
Hi Lorenzo & Everyone, Many thanks. I have picked this up and doing the review and testing now and
will
soon get back to you with initial results with this new branch.
Many thanks Salil
-----Original Message----- From: Lorenzo Pieralisi via Linaro-open-discussions [mailto:linaro-open-discussions@op-lists.linaro.org] Sent: Tuesday, August 23, 2022 4:10 PM To: linaro-open-discussions@op-lists.linaro.org Cc: James Morse james.morse@arm.com Subject: [Linaro-open-discussions] ARM64 virt CPU HP - plan
Hi all,
in the meeting held today we decided to go ahead as follows in relation to ARM64 virt CPU hotplug patches and QEmu changes:
- James requires QEmu changes to test his branch[1]
- Huawei (Salil) agreed to upgrade the QEmu patches to the latest ACPI specs (and James' code [1])
- QEmu updates will be given with a branch/link in reply to this email thread so that James can complete [1] testing against them
- Any testing, bug report, communication will take place through this mailing list before public posting on a kernel ML, so please keep an eye on this thread if you'd like to collaborate/help
- It would be good to get some feedback from containers/kubernetes developers on the full software stack - after all we are making these changes to enable the ecosystem
Please chime in if I forgot something or reach out, all comments are welcome.
Lorenzo
[1]
https://gitlab.arm.com/linux-arm/linux-jm/-/tree/virtual_cpu_hotplug/rfc/v0
-- Linaro-open-discussions mailing list -- linaro-open-discussions@op-lists.linaro.org https://collaborate.linaro.org/display/LOD/Linaro+Open+Discussions+Home
Hi Salil,
Please share qemu repo/branch which works with James kernel repo?
Thanks, Ganapat
Hi Ganpat, I have to forward port the patches to the latest QEMU and then sanity test before I can share the code. There are lots of changes which have trickled into the QEmu which have caused conflicts. I am reviewing them carefully to ensure we don't end up debugging something unnecessary as it will waste everyone's time and duplicate the efforts. Once this is done I will do the sanity testing along with James repository.
Ideally, I should be able to share the code by COB tomorrow if I find no blockers during testing (which I do not see as of now).
Many thanks Salil
-----Original Message----- From: gankulkarni--- via Linaro-open-discussions [mailto:linaro-open-discussions@op-lists.linaro.org] Sent: Tuesday, August 30, 2022 9:05 AM To: linaro-open-discussions@op-lists.linaro.org Subject: [Linaro-open-discussions] Re: ARM64 virt CPU HP - plan
Hi Salil,
Please share qemu repo/branch which works with James kernel repo?
Thanks, Ganapat -- Linaro-open-discussions mailing list -- linaro-open-discussions@op-lists.linaro.org https://collaborate.linaro.org/display/LOD/Linaro+Open+Discussions+Home
Hi Salil,
On 31/08/2022 09:19, Salil Mehta wrote:
Hi Ganpat, I have to forward port the patches to the latest QEMU and then sanity test before I can share the code. There are lots of changes which have trickled into the QEmu which have caused conflicts. I am reviewing them carefully to ensure we don't end up debugging something unnecessary as it will waste everyone's time and duplicate the efforts. Once this is done I will do the sanity testing along with James repository.
Ideally, I should be able to share the code by COB tomorrow if I find no blockers during testing (which I do not see as of now).
Beware the WFI in user-space support that is needed for implementing CPU_SUSPEND is a little different from the previous version. From memory the change is how the vCPU gets restarted....
Thanks,
James
HI James,
From: James Morse [mailto:james.morse@arm.com] Sent: Wednesday, August 31, 2022 1:52 PM To: Salil Mehta salil.mehta@huawei.com; gankulkarni@os.amperecomputing.com Cc: linaro-open-discussions@op-lists.linaro.org; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org; Jonathan Cameron jonathan.cameron@huawei.com; mehta.salil.lnk@gmail.com Subject: Re: [Linaro-open-discussions] Re: ARM64 virt CPU HP - plan
Hi Salil,
On 31/08/2022 09:19, Salil Mehta wrote:
Hi Ganpat, I have to forward port the patches to the latest QEMU and then sanity test before I can share the code. There are lots of changes which have trickled into the QEmu which have caused conflicts. I am reviewing them carefully to ensure we don't end up debugging something unnecessary as it will waste everyone's time and duplicate the efforts. Once this is done I will do the sanity testing along with James repository.
Ideally, I should be able to share the code by COB tomorrow if I find no blockers during testing (which I do not see as of now).
Beware the WFI in user-space support that is needed for implementing CPU_SUSPEND is a little different from the previous version. From memory the change is how the vCPU gets restarted....
I see. thanks for sharing this info. It might be helpful if you have reference to lore.kernel patches where it got changed?
Thanks Salil.
Thanks,
James
Hi James,
-----Original Message----- From: Salil Mehta via Linaro-open-discussions [mailto:linaro-open-discussions@op-lists.linaro.org] Sent: Wednesday, August 31, 2022 2:01 PM To: James Morse james.morse@arm.com; gankulkarni@os.amperecomputing.com Cc: linaro-open-discussions@op-lists.linaro.org; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org Subject: [Linaro-open-discussions] Re: ARM64 virt CPU HP - plan
HI James,
From: James Morse [mailto:james.morse@arm.com] Sent: Wednesday, August 31, 2022 1:52 PM To: Salil Mehta salil.mehta@huawei.com; gankulkarni@os.amperecomputing.com Cc: linaro-open-discussions@op-lists.linaro.org; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org; Jonathan Cameron jonathan.cameron@huawei.com; mehta.salil.lnk@gmail.com Subject: Re: [Linaro-open-discussions] Re: ARM64 virt CPU HP - plan
Hi Salil,
On 31/08/2022 09:19, Salil Mehta wrote:
Hi Ganpat, I have to forward port the patches to the latest QEMU and then sanity test before I can share the code. There are lots of changes which have trickled into the QEmu which have caused conflicts. I am reviewing them carefully
to
ensure we don't end up debugging something unnecessary as it will waste everyone's time and duplicate the efforts. Once this is done I will do the sanity testing along with James repository.
Ideally, I should be able to share the code by COB tomorrow if I find no blockers during testing (which I do not see as of now).
Beware the WFI in user-space support that is needed for implementing CPU_SUSPEND is a little different from the previous version. From memory the change is how the vCPU gets restarted....
I see. thanks for sharing this info. It might be helpful if you have reference to lore.kernel patches where it got changed?
Aah, got it. Perhaps this patch? Yes, I can see what you mean.
[RFC PATCH 2/5] KVM: arm64: Move WFI execution to check_vcpu_requests() https://lore.kernel.org/kvm/20210608154805.216869-1-jean-philippe@linaro.org...
Thanks Salil.
Hi Salil,
On 01/09/2022 10:02, Salil Mehta wrote:
From: Salil Mehta via Linaro-open-discussions
Ideally, I should be able to share the code by COB tomorrow if I find no blockers during testing (which I do not see as of now).
Beware the WFI in user-space support that is needed for implementing CPU_SUSPEND is a little different from the previous version. From memory the change is how the vCPU gets restarted....
I see. thanks for sharing this info. It might be helpful if you have reference to lore.kernel patches where it got changed?
Aah, got it. Perhaps this patch? Yes, I can see what you mean.
[RFC PATCH 2/5] KVM: arm64: Move WFI execution to check_vcpu_requests() https://lore.kernel.org/kvm/20210608154805.216869-1-jean-philippe@linaro.org...
Yes, that was what Jean's qemu work originally supported, but since then mainline has merged 7b33a09d036f ("KVM: arm64: Add support for userspace to suspend a vCPU"), which is similar, but different.
Most of that patch from Jean got folded out in the rebase, and mainline now has some difference in the way the user-space interface behaves.
Thanks,
James
Hi James,
From: James Morse [mailto:james.morse@arm.com] Sent: Thursday, September 1, 2022 12:00 PM To: Salil Mehta salil.mehta@huawei.com; gankulkarni@os.amperecomputing.com Cc: linaro-open-discussions@op-lists.linaro.org; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org; Jonathan Cameron jonathan.cameron@huawei.com; mehta.salil.lnk@gmail.com Subject: Re: [Linaro-open-discussions] Re: ARM64 virt CPU HP - plan
Hi Salil,
On 01/09/2022 10:02, Salil Mehta wrote:
From: Salil Mehta via Linaro-open-discussions
Ideally, I should be able to share the code by COB tomorrow if I find no blockers during testing (which I do not see as of now).
Beware the WFI in user-space support that is needed for implementing
CPU_SUSPEND
is a little different from the previous version. From memory the change is how
the
vCPU gets restarted....
I see. thanks for sharing this info. It might be helpful if you have reference to lore.kernel patches where it got changed?
Aah, got it. Perhaps this patch? Yes, I can see what you mean.
[RFC PATCH 2/5] KVM: arm64: Move WFI execution to check_vcpu_requests()
https://lore.kernel.org/kvm/20210608154805.216869-1-jean-philippe@linaro.or g/T/#mf696d88845f7467f4c0b7388becfdd23e3437c78
Yes, that was what Jean's qemu work originally supported, but since then mainline has merged 7b33a09d036f ("KVM: arm64: Add support for userspace to suspend a vCPU"), which is similar, but different.
Most of that patch from Jean got folded out in the rebase, and mainline now has some difference in the way the user-space interface behaves.
I see. So if I got you correctly, we might need some change in the userspace PSCI QEMU handling as well over the Jean's PSCI patches (as they might not work out-of-the-box) to reflect the merged change in the mainline kernel?
Thanks Salil.
Hi Salil,
On 01/09/2022 12:48, Salil Mehta wrote:
I see. So if I got you correctly, we might need some change in the userspace PSCI QEMU handling as well over the Jean's PSCI patches (as they might not work out-of-the-box) to reflect the merged change in the mainline kernel?
Spot on. Sorry if I wasn't clear in what I said!
Thanks,
James
Hi James,
From: James Morse [mailto:james.morse@arm.com] Sent: Thursday, September 1, 2022 1:55 PM To: Salil Mehta salil.mehta@huawei.com; gankulkarni@os.amperecomputing.com Cc: linaro-open-discussions@op-lists.linaro.org; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org; Jonathan Cameron jonathan.cameron@huawei.com; mehta.salil.lnk@gmail.com Subject: Re: [Linaro-open-discussions] Re: ARM64 virt CPU HP - plan
Hi Salil,
On 01/09/2022 12:48, Salil Mehta wrote:
I see. So if I got you correctly, we might need some change in the userspace PSCI QEMU handling as well over the Jean's PSCI patches (as they might not
work
out-of-the-box) to reflect the merged change in the mainline kernel?
Spot on. Sorry if I wasn't clear in what I said!
Thanks, I will modify the Qemu code to handle this and add new patches.
Cheers Salil.
linaro-open-discussions@op-lists.linaro.org
-
gankulkarni＠os.amperecomputing.com -
James Morse -
Lorenzo Pieralisi -
Salil Mehta