Hi Salil,
I find a bug about your patch. When I start VM using your Qemu's virt-cpuhp-armv8/rfc-v2 branch, an error occurs:
[error log start] qemu-system-aarch64: Failed to initialize host vcpu 1 [error log end]
I try to fix it by the following change:
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 3bfe9b9db3..8bd52742e7 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2444,6 +2444,7 @@ static void machvirt_init(MachineState *machine) * GICC and GICR with the all possible vcpus for this VM. */ if (kvm_enabled()) { + arm_cpu_sve_finalize(ARM_CPU(cs), &error_fatal); kvm_arm_create_host_vcpu(ARM_CPU(cs)); } /*
So, is there lack of sve finalize before creating vcpu?
Thanks Jianyong
-----Original Message----- From: Salil Mehta salil.mehta@huawei.com Sent: 2023年11月6日 21:38 To: Jianyong Wu Jianyong.Wu@arm.com; Russell King linux@armlinux.org.uk; James Morse James.Morse@arm.com Cc: linaro-open-discussions@op-lists.linaro.org; Joyce Qi joyce.qi@linaro.org; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org; karl.heubaum@oracle.com; darren@os.amperecomputing.com; ilkka@os.amperecomputing.com; miguel.luis@oracle.com; vishnu@os.amperecomputing.com; Linuxarm linuxarm@huawei.com; salil.mehta@opnsrc.net Subject: RE: [Linaro-open-discussions] Re: [Request] Regarding non-RFC patch-set of Virtual CPU Hotplug kernel support
Hi Jianyong,
From: Jianyong Wu Jianyong.Wu@arm.com Sent: Friday, November 3, 2023 9:42 AM To: Russell King linux@armlinux.org.uk; James Morse James.Morse@arm.com; Salil Mehta salil.mehta@huawei.com Cc: linaro-open-discussions@op-lists.linaro.org; Joyce Qi joyce.qi@linaro.org; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org; karl.heubaum@oracle.com; darren@os.amperecomputing.com; ilkka@os.amperecomputing.com; miguel.luis@oracle.com; vishnu@os.amperecomputing.com; Linuxarm linuxarm@huawei.com; salil.mehta@opnsrc.net Subject: RE: [Linaro-open-discussions] Re: [Request] Regarding non-RFC patch-set of Virtual CPU Hotplug kernel support
Hello Russell,
Thanks for your link. One question: what's the difference between your git tree with James'. I used to get James' code from git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git in branch of virtual_cpu_hotplug
I have just done an initial test integrating James' and Salil's patch with kata containers on Arm and it functions well. Also, I have a plan to add an integration test CI in kata community for Vcpu Hotplug on Arm. There we can do more tests integrating with k8s. To do the test, I need a stable git link of Kernel and Qemu including the latest change, thus, I can clone the code from a fixed source in each test. It's very helpful if you guys could aid.
Please use Qemu repositories mentioned in the below link https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v2
Thanks Salil.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.