Hi Salil,
From the discussion at https://lore.kernel.org/lkml/8634x522z2.wl-maz@kernel.org/T/, I think you can check SMCCC_FILTER in kvm host using KVM_HAS_DEVICE_ATTR and I find that you have done that in RFCv2 but don't abort once error out. WDYT?
Thanks Jianyong
-----Original Message----- From: Salil Mehta salil.mehta@huawei.com Sent: 2023年11月11日 0:40 To: Russell King linux@armlinux.org.uk Cc: Jianyong Wu Jianyong.Wu@arm.com; James Morse James.Morse@arm.com; linaro-open-discussions@op-lists.linaro.org; Joyce Qi joyce.qi@linaro.org; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org; karl.heubaum@oracle.com; darren@os.amperecomputing.com; ilkka@os.amperecomputing.com; miguel.luis@oracle.com; vishnu@os.amperecomputing.com; Linuxarm linuxarm@huawei.com; salil.mehta@opnsrc.net Subject: RE: [Linaro-open-discussions] Re: [Request] Regarding non-RFC patch-set of Virtual CPU Hotplug kernel support
Hi Russell,
From: Russell King linux@armlinux.org.uk Sent: Friday, November 10, 2023 4:21 PM To: Salil Mehta salil.mehta@huawei.com
On Mon, Nov 06, 2023 at 01:38:26PM +0000, Salil Mehta wrote:
Hi Jianyong,
From: Jianyong Wu Jianyong.Wu@arm.com Sent: Friday, November 3, 2023 9:42 AM To: Russell King linux@armlinux.org.uk; James Morse James.Morse@arm.com; Salil Mehta salil.mehta@huawei.com Cc: linaro-open-discussions@op-lists.linaro.org; Joyce Qi joyce.qi@linaro.org; Lorenzo Pieralisi lorenzo.pieralisi@linaro.org; karl.heubaum@oracle.com; darren@os.amperecomputing.com; ilkka@os.amperecomputing.com; miguel.luis@oracle.com; vishnu@os.amperecomputing.com; Linuxarm linuxarm@huawei.com; salil.mehta@opnsrc.net Subject: RE: [Linaro-open-discussions] Re: [Request] Regarding non-RFC patch-set of Virtual CPU Hotplug kernel support
Hello Russell,
Thanks for your link. One question: what's the difference between your git tree with James'. I used to get James' code from git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git in branch of virtual_cpu_hotplug
I have just done an initial test integrating James' and Salil's patch with kata containers on Arm and it functions well. Also, I have a plan to add an integration test CI in kata community for Vcpu Hotplug on Arm. There we can do more tests integrating with k8s. To do the test, I need a stable git link of Kernel and Qemu including the latest change, thus, I can clone the code from a fixed source in each test. It's very helpful if you guys could aid.
Please use Qemu repositories mentioned in the below link https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v2
Hi Salil,
What is the earliest _host_ kernel that this version of qemu is expected to inter-operate with?
Whatever is the kernel corresponding to the below repository of James,
[...]/morse/linux.git virtual_cpu_hotplug/rfc/v2
Earlier kernel would require changes. Before RFC V2, I have been using my own ported version of 2 of the James private branches part of repository,
[...]linux-arm/Linux-jm.git
Oracle's UEK7 kernels (current) are based off 5.15-stable, and it appears that this version of qemu requires KVM_ARM_SMCCC_FILTER support which was introduced in v6.4-rc1 - which is a particularly recent kernel.
Yes, all these changes. You can try using below branch I ported for my own testing (but with a caution - I mean no strings attached :|),
https://github.com/salil-mehta/linux/tree/vcpuhp-rfc-v1-jm-20230224-port-6.4... rc2-20230516
I'm guessing that vcpu hotplug requires that so it can filter the PSCI ops, but please note the dependency requirement.
That's correct. I ported above branch at start of May so it already Had those Oliver Upton's SMCC Filter changes part of the kernel.
Thanks Salil.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.