From: Carsten Haitzler carsten.haitzler@foss.arm.com
Use proper type for arg to match other changes in kernel tree.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com --- drivers/hid/usbhid/hiddev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c index 2fb2991dbe4c..3a4478da66ca 100644 --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c @@ -591,7 +591,7 @@ static noinline int hiddev_ioctl_string(struct hiddev *hiddev, unsigned int cmd, return len; }
-static long hiddev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +static long hiddev_ioctl(struct file *file, unsigned int cmd, user_uintptr_t arg) { struct hiddev_list *list = file->private_data; struct hiddev *hiddev = list->hiddev;
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Enable a range of config options to have USB HID devices and related input devices build so we can run a proper UI with input working too in morello_transitional_pcuabi_defconfig.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com --- arch/arm64/configs/morello_transitional_pcuabi_defconfig | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm64/configs/morello_transitional_pcuabi_defconfig b/arch/arm64/configs/morello_transitional_pcuabi_defconfig index 1db4601197a3..05520ad9f09e 100644 --- a/arch/arm64/configs/morello_transitional_pcuabi_defconfig +++ b/arch/arm64/configs/morello_transitional_pcuabi_defconfig @@ -165,3 +165,7 @@ CONFIG_DEBUG_FS=y # CONFIG_DEBUG_PREEMPT is not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y +CONFIG_USB_HIDDEV=y +CONFIG_I2C_HID_ACPI=y +CONFIG_INPUT_MOUSEDEV=y +CONFIG_INPUT_EVDEV=y
On 25/01/2023 09:00, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Enable a range of config options to have USB HID devices and related input devices build so we can run a proper UI with input working too in morello_transitional_pcuabi_defconfig.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com
arch/arm64/configs/morello_transitional_pcuabi_defconfig | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm64/configs/morello_transitional_pcuabi_defconfig b/arch/arm64/configs/morello_transitional_pcuabi_defconfig index 1db4601197a3..05520ad9f09e 100644 --- a/arch/arm64/configs/morello_transitional_pcuabi_defconfig +++ b/arch/arm64/configs/morello_transitional_pcuabi_defconfig @@ -165,3 +165,7 @@ CONFIG_DEBUG_FS=y # CONFIG_DEBUG_PREEMPT is not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y +CONFIG_USB_HIDDEV=y +CONFIG_I2C_HID_ACPI=y +CONFIG_INPUT_MOUSEDEV=y +CONFIG_INPUT_EVDEV=y
It would be better to replace the defconfig with exactly the output of make savedefconfig, as I don't think the new options are generated in that position in the file. Doing this guarantees that updates to the defconfig are stable and easy to diff.
Kevin
On 1/25/23 08:55, Kevin Brodsky wrote:
On 25/01/2023 09:00, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Enable a range of config options to have USB HID devices and related input devices build so we can run a proper UI with input working too in morello_transitional_pcuabi_defconfig.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com
arch/arm64/configs/morello_transitional_pcuabi_defconfig | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm64/configs/morello_transitional_pcuabi_defconfig b/arch/arm64/configs/morello_transitional_pcuabi_defconfig index 1db4601197a3..05520ad9f09e 100644 --- a/arch/arm64/configs/morello_transitional_pcuabi_defconfig +++ b/arch/arm64/configs/morello_transitional_pcuabi_defconfig @@ -165,3 +165,7 @@ CONFIG_DEBUG_FS=y # CONFIG_DEBUG_PREEMPT is not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y +CONFIG_USB_HIDDEV=y +CONFIG_I2C_HID_ACPI=y +CONFIG_INPUT_MOUSEDEV=y +CONFIG_INPUT_EVDEV=y
It would be better to replace the defconfig with exactly the output of make savedefconfig, as I don't think the new options are generated in that position in the file. Doing this guarantees that updates to the defconfig are stable and easy to diff.
They are indeed not in that order - I put them at the end more as a easier to handle patch so new opts are justr a block at the end - but if you're going to pass it through savedefconfig regularly... then just re-pass-it through then :)
On 25/01/2023 13:03, Carsten Haitzler wrote:
On 1/25/23 08:55, Kevin Brodsky wrote:
On 25/01/2023 09:00, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Enable a range of config options to have USB HID devices and related input devices build so we can run a proper UI with input working too in morello_transitional_pcuabi_defconfig.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com
arch/arm64/configs/morello_transitional_pcuabi_defconfig | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm64/configs/morello_transitional_pcuabi_defconfig b/arch/arm64/configs/morello_transitional_pcuabi_defconfig index 1db4601197a3..05520ad9f09e 100644 --- a/arch/arm64/configs/morello_transitional_pcuabi_defconfig +++ b/arch/arm64/configs/morello_transitional_pcuabi_defconfig @@ -165,3 +165,7 @@ CONFIG_DEBUG_FS=y # CONFIG_DEBUG_PREEMPT is not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y +CONFIG_USB_HIDDEV=y +CONFIG_I2C_HID_ACPI=y +CONFIG_INPUT_MOUSEDEV=y +CONFIG_INPUT_EVDEV=y
It would be better to replace the defconfig with exactly the output of make savedefconfig, as I don't think the new options are generated in that position in the file. Doing this guarantees that updates to the defconfig are stable and easy to diff.
They are indeed not in that order - I put them at the end more as a easier to handle patch so new opts are justr a block at the end - but if you're going to pass it through savedefconfig regularly... then just re-pass-it through then :)
Sure, I've taken care of that and amended the commit title tag as suggested, all of that is now in next. Thanks!
Kevin
linux-morello@op-lists.linaro.org
-
Carsten Haitzler -
carsten.haitzler＠foss.arm.com
-
Kevin Brodsky