From: Carsten Haitzler carsten.haitzler@foss.arm.com
Use proper type for arg to match other changes in kernel tree.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com --- drivers/hid/usbhid/hiddev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c index 2fb2991dbe4c..3a4478da66ca 100644 --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c @@ -591,7 +591,7 @@ static noinline int hiddev_ioctl_string(struct hiddev *hiddev, unsigned int cmd, return len; }
-static long hiddev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +static long hiddev_ioctl(struct file *file, unsigned int cmd, user_uintptr_t arg) { struct hiddev_list *list = file->private_data; struct hiddev *hiddev = list->hiddev;
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Enable a range of config options to have USB HID devices and related input devices build so we can run a proper UI with input working too in morello_transitional_pcuabi_defconfig.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com --- .../configs/morello_transitional_pcuabi_defconfig | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/arch/arm64/configs/morello_transitional_pcuabi_defconfig b/arch/arm64/configs/morello_transitional_pcuabi_defconfig index 1db4601197a3..1f51440de6ea 100644 --- a/arch/arm64/configs/morello_transitional_pcuabi_defconfig +++ b/arch/arm64/configs/morello_transitional_pcuabi_defconfig @@ -165,3 +165,14 @@ CONFIG_DEBUG_FS=y # CONFIG_DEBUG_PREEMPT is not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y +CONFIG_USB_HID=y +CONFIG_USB_HIDDEV=y +CONFIG_USB_KBD=y +CONFIG_USB_MOUSE=y +CONFIG_I2C_HID_ACPI=y +CONFIG_HID_GENERIC=y +CONFIG_INPUT=y +CONFIG_INPUT_MOUSEDEV=y +CONFIG_INPUT_EVDEV=y +CONFIG_INPUT_KEYBOARD=y +CONFIG_INPUT_MOUSE=y
The tag should be "arm64: morello:" for everything Morello-specific. Would also be good to say in the title it's about the defconfig.
On 24/01/2023 15:08, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Enable a range of config options to have USB HID devices and related input devices build so we can run a proper UI with input working too in morello_transitional_pcuabi_defconfig.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com
.../configs/morello_transitional_pcuabi_defconfig | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/arch/arm64/configs/morello_transitional_pcuabi_defconfig b/arch/arm64/configs/morello_transitional_pcuabi_defconfig index 1db4601197a3..1f51440de6ea 100644 --- a/arch/arm64/configs/morello_transitional_pcuabi_defconfig +++ b/arch/arm64/configs/morello_transitional_pcuabi_defconfig @@ -165,3 +165,14 @@ CONFIG_DEBUG_FS=y # CONFIG_DEBUG_PREEMPT is not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y +CONFIG_USB_HID=y +CONFIG_USB_HIDDEV=y +CONFIG_USB_KBD=y +CONFIG_USB_MOUSE=y +CONFIG_I2C_HID_ACPI=y +CONFIG_HID_GENERIC=y +CONFIG_INPUT=y +CONFIG_INPUT_MOUSEDEV=y +CONFIG_INPUT_EVDEV=y +CONFIG_INPUT_KEYBOARD=y +CONFIG_INPUT_MOUSE=y
As usual, the defconfig should be regenerated with make savedefconfig (I think many of these options are implied as they don't appear in the standard defconfig).
Kevin
arm64: morello: Would be going against Vincenzo's own tagging for the exact same thing like:
[linux-morello] [PATCH 09/10] morello: Enable GPU/DPU in defconfig [linux-morello] [PATCH 10/10] morello: Enable RTC support
Which is why is the pattern I chose to continue as it follows in the same vein. I can sneak in a defconfig there.
On 1/24/23 17:01, Kevin Brodsky wrote:
The tag should be "arm64: morello:" for everything Morello-specific. Would also be good to say in the title it's about the defconfig.
On 24/01/2023 15:08, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Enable a range of config options to have USB HID devices and related input devices build so we can run a proper UI with input working too in morello_transitional_pcuabi_defconfig.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com
.../configs/morello_transitional_pcuabi_defconfig | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/arch/arm64/configs/morello_transitional_pcuabi_defconfig b/arch/arm64/configs/morello_transitional_pcuabi_defconfig index 1db4601197a3..1f51440de6ea 100644 --- a/arch/arm64/configs/morello_transitional_pcuabi_defconfig +++ b/arch/arm64/configs/morello_transitional_pcuabi_defconfig @@ -165,3 +165,14 @@ CONFIG_DEBUG_FS=y # CONFIG_DEBUG_PREEMPT is not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y +CONFIG_USB_HID=y +CONFIG_USB_HIDDEV=y +CONFIG_USB_KBD=y +CONFIG_USB_MOUSE=y +CONFIG_I2C_HID_ACPI=y +CONFIG_HID_GENERIC=y +CONFIG_INPUT=y +CONFIG_INPUT_MOUSEDEV=y +CONFIG_INPUT_EVDEV=y +CONFIG_INPUT_KEYBOARD=y +CONFIG_INPUT_MOUSE=y
As usual, the defconfig should be regenerated with make savedefconfig (I think many of these options are implied as they don't appear in the standard defconfig).
I never knew about savedefconfig - I was nuking options by hand (and I cut out ~ 3/4 of the config opts I had added to get to the above). Will use that.
Kevin
On 25/01/2023 08:54, Carsten Haitzler wrote:
arm64: morello: Would be going against Vincenzo's own tagging for the exact same thing like:
[linux-morello] [PATCH 09/10] morello: Enable GPU/DPU in defconfig [linux-morello] [PATCH 10/10] morello: Enable RTC support
Which is why is the pattern I chose to continue as it follows in the same vein. I can sneak in a defconfig there.
I mentioned earlier that they should be renamed to "arm64: morello:" (to align with all of our patches so far), Vincenzo agreed but probably forgot to change them. If that's alright I'll change yours too.
Kevin
On 1/25/23 08:53, Kevin Brodsky wrote:
On 25/01/2023 08:54, Carsten Haitzler wrote:
arm64: morello: Would be going against Vincenzo's own tagging for the exact same thing like:
[linux-morello] [PATCH 09/10] morello: Enable GPU/DPU in defconfig [linux-morello] [PATCH 10/10] morello: Enable RTC support
Which is why is the pattern I chose to continue as it follows in the same vein. I can sneak in a defconfig there.
I mentioned earlier that they should be renamed to "arm64: morello:" (to align with all of our patches so far), Vincenzo agreed but probably forgot to change them. If that's alright I'll change yours too.
Sorry my bad, clearly forgot to change the tags here. If you want I can re-post.
Kevin _______________________________________________ linux-morello mailing list -- linux-morello@op-lists.linaro.org To unsubscribe send an email to linux-morello-leave@op-lists.linaro.org
On 25/01/2023 10:21, Vincenzo Frascino wrote:
Sorry my bad, clearly forgot to change the tags here. If you want I can re-post.
No worries, no need to repost, I need to amend the commit messages to add some S-o-b / Tested-by anyway.
Kevin
On 1/25/23 08:53, Kevin Brodsky wrote:
On 25/01/2023 08:54, Carsten Haitzler wrote:
arm64: morello: Would be going against Vincenzo's own tagging for the exact same thing like:
[linux-morello] [PATCH 09/10] morello: Enable GPU/DPU in defconfig [linux-morello] [PATCH 10/10] morello: Enable RTC support
Which is why is the pattern I chose to continue as it follows in the same vein. I can sneak in a defconfig there.
I mentioned earlier that they should be renamed to "arm64: morello:" (to align with all of our patches so far), Vincenzo agreed but probably forgot to change them. If that's alright I'll change yours too.
oh .. i didn't see any replies from you on those patches asking for that. just was following the pattern. i can change the tag if you want - i already posted v2's with all the other changes
Nit: looks like the most common title tag for these files is "HID: hiddev:"
While at it, maybe could say "ioctl arg" to suggest we're talking about an ioctl handler?
Kevin
On 24/01/2023 15:08, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Use proper type for arg to match other changes in kernel tree.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com
drivers/hid/usbhid/hiddev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c index 2fb2991dbe4c..3a4478da66ca 100644 --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c @@ -591,7 +591,7 @@ static noinline int hiddev_ioctl_string(struct hiddev *hiddev, unsigned int cmd, return len; } -static long hiddev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +static long hiddev_ioctl(struct file *file, unsigned int cmd, user_uintptr_t arg) { struct hiddev_list *list = file->private_data; struct hiddev *hiddev = list->hiddev;
Fixed tag - indeed I didn't look - I went by tree which was in usbhid.
On 1/24/23 16:58, Kevin Brodsky wrote:
Nit: looks like the most common title tag for these files is "HID: hiddev:"
While at it, maybe could say "ioctl arg" to suggest we're talking about an ioctl handler?
Kevin
On 24/01/2023 15:08, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Use proper type for arg to match other changes in kernel tree.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com
drivers/hid/usbhid/hiddev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c index 2fb2991dbe4c..3a4478da66ca 100644 --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c @@ -591,7 +591,7 @@ static noinline int hiddev_ioctl_string(struct hiddev *hiddev, unsigned int cmd, return len; } -static long hiddev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +static long hiddev_ioctl(struct file *file, unsigned int cmd, user_uintptr_t arg) { struct hiddev_list *list = file->private_data; struct hiddev *hiddev = list->hiddev;
Fixed tag - indeed I didn't look - I went by tree which was in usbhid.
On 1/24/23 16:58, Kevin Brodsky wrote:
Nit: looks like the most common title tag for these files is "HID: hiddev:"
While at it, maybe could say "ioctl arg" to suggest we're talking about an ioctl handler?
Kevin
On 24/01/2023 15:08, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@foss.arm.com
Use proper type for arg to match other changes in kernel tree.
Signed-off-by: Carsten Haitzler Carsten.Haitzler@arm.com
drivers/hid/usbhid/hiddev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c index 2fb2991dbe4c..3a4478da66ca 100644 --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c @@ -591,7 +591,7 @@ static noinline int hiddev_ioctl_string(struct hiddev *hiddev, unsigned int cmd, return len; } -static long hiddev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +static long hiddev_ioctl(struct file *file, unsigned int cmd, user_uintptr_t arg) { struct hiddev_list *list = file->private_data; struct hiddev *hiddev = list->hiddev;
linux-morello@op-lists.linaro.org
-
Carsten Haitzler -
carsten.haitzler＠foss.arm.com
-
Kevin Brodsky -
Vincenzo Frascino