On 15/09/2023 15:44, Kevin Brodsky wrote:
On 12/09/2023 11:51, Zachary Leaf wrote:
in_32bit_compat_syscall() + is_32bit_compat_task() were originally named to be consistent with is_32bit_compat_thread() from asm/compat.h in the commit ("arch: add compat helpers specific to 32-bit").
AFAICT it is the other way round: first the generic helpers were introduced, then the arm64-specific is_compat_thread() was renamed [1]. As long as Kristina doesn't see an issue with the renaming, neither do I, but I would prefer the renaming to be complete (all compat32 helpers including the arm64 ones).
Kevin
[1] https://git.morello-project.org/morello/kernel/linux/-/commit/a53b230b237d3c...
Indeed, I think they were named to be consistent with is_32bit_task(), not is_32bit_compat_thread().
I don't see any issue with renaming them, looks good to me. (And I would also have a slight preference for renaming all of them. is_32bit_task() is a bit different anyway (it's not compat).)
Thanks, Kristina