[linux-morello] Re: [PATCH v4 11/13] bpf: use user pointer types in uAPI structs

On 06/11/2023 11:29, Kevin Brodsky wrote:

On 30/10/2023 13:48, Zachary Leaf wrote:

...

diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index c994ff5b157c..a536d8f8805e 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -1350,21 +1350,21 @@ union bpf_attr { struct { /* anonymous struct used by BPF_MAP_*_ELEM commands */ __u32 map_fd;

• __aligned_u64	key;
  

• __kernel_aligned_uintptr_t key;
  

  union {

• 	__aligned_u64 value;
  

• 	__aligned_u64 next_key;
  

• 	__kernel_aligned_uintptr_t value;
  

• 	__kernel_aligned_uintptr_t next_key;
  

Aren't we missing some bpf_compat_ptr_field() for these key fields?

Reading further, it seems that we are missing it for many more fields, for instance prog_ids and prog_attach_flags.

Ah yeah. Not sure what happened there. Looks like I left a few out when we moved to copy_field/bpf_compat_ptr_field i.e. v1..v2.

That should have fixed it.

Thanks, Zach

Kevin