On 9/1/22 09:58, Kevin Brodsky wrote:
On 31/08/2022 16:37, Vincenzo Frascino wrote:
Since native AArch64 uses the keyctl handler, let's do that for 64-bit compat as well.
Note: This fixes a silent error that prevents running docker correctly in compat64 mode.
Signed-off-by: Vincenzo Frascino vincenzo.frascino@arm.com
arch/arm64/kernel/sys_compat64.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/sys_compat64.c b/arch/arm64/kernel/sys_compat64.c index 819b895ec21d..6cbf58d4a6e7 100644 --- a/arch/arm64/kernel/sys_compat64.c +++ b/arch/arm64/kernel/sys_compat64.c @@ -82,6 +82,7 @@ #define __arm64_compatentry_compat_sys_getitimer __arm64_compatentry_sys_getitimer #define __arm64_compatentry_compat_sys_setitimer __arm64_compatentry_sys_setitimer #define __arm64_compatentry_compat_sys_getrusage __arm64_compatentry_sys_getrusage +#define __arm64_compatentry_compat_sys_keyctl __arm64_compatentry_sys_keyctl
This works, but overall we have tried to avoid this approach as it can be rather confusing to have a compat handler that is simply unused, and it is also rather ad-hoc. It's a trade-off, sometimes making the compat handler work for compat64 is just not worth it. However it seems that in that case it would be just a two-line change in security/keys/compat.c, replacing the u32's in the signature with compat_ulong_t. What do you think?
I think that both the approaches are acceptable. I can try to have a look and see if changing the signature is sufficient.
Kevin
asmlinkage long sys_ni_syscall(void);
linux-morello mailing list -- linux-morello@op-lists.linaro.org To unsubscribe send an email to linux-morello-leave@op-lists.linaro.org