On 23/02/2023 11:42, Beata Michalska wrote:
Hi Kevin,
It all looks goot to me.
Thanks for the final review! Now in next.
Kevin
BR B. On Thu, Feb 16, 2023 at 08:38:21AM +0000, Kevin Brodsky wrote:
Hi,
This is a fairly small update to this series, see the cover letter of v2 for more information. v3 addresses comments from Beata and Amit, thanks for the reviews!
v2..v3:
- "pps: Add missing #include" (patch 1 in v2) merged in next separately.
- Renamed cheri_user_root_all_cap to cheri_user_root_allperms_cap.
- Added reference to upstream commit removing CONFIG_SET_FS (patch 1).
- Made cheri_check_cap() take a const capability (patch 4).
- Rewrote the initialisation of root capabilities, using a new build_cap() helper (patch 5).
- Added CAP_OTYPE_FIELD_BITS to calculate the number of object types (patch 5).
- Rebased on 6.1 (some conflicts but all trivial).
Review branch:
https://git.morello-project.org/kbrodsky-arm/linux/-/commits/morello/cheri_p...
Thanks, Kevin
Kevin Brodsky (14): linux/user_ptr.h: Remove kaddr_to_user_ptr() linux/user_ptr.h: Improve comment formatting arm64: uapi: Add asm/cheri.h linux/cheri.h: Introduce CHERI helpers arm64: morello: Implement cheri.h fs/binfmt_elf: Use appropriate caps for AT_CHERI_{SEAL,CID}_CAP arm64: compat: Use appropriate root cap in compat_ptr() in PCuABI linux/user_ptr.h: Generic PCuABI impl for uaddr_to_user_ptr* arm64: Remove asm/user_ptr.h arm64: morello: Initialise user capabilities from cheri_user_root_* arm64: morello: Initialise user DDC from cheri_user_root_* arm64: morello: Build arbitrary user caps using appropriate root arm64: morello: Remove morello_root_cap arm64: morello: Update root capability in documentation
Documentation/arm64/morello.rst | 23 +++-- Documentation/core-api/user_ptr.rst | 8 -- arch/Kconfig | 2 +- arch/arm64/Kconfig | 2 +- arch/arm64/include/asm/cheri.h | 11 ++ arch/arm64/include/asm/compat.h | 9 +- arch/arm64/include/asm/morello.h | 12 ++- arch/arm64/include/asm/user_ptr.h | 43 -------- arch/arm64/include/uapi/asm/cheri.h | 11 ++ arch/arm64/kernel/morello.c | 152 +++++++++++++++++----------- arch/arm64/kernel/process.c | 2 +- arch/arm64/kernel/ptrace.c | 2 +- arch/arm64/lib/morello.S | 17 ++-- fs/binfmt_elf.c | 10 +- include/linux/cheri.h | 134 ++++++++++++++++++++++++ include/linux/user_ptr.h | 69 ++++++------- lib/Makefile | 3 + lib/cheri.c | 73 +++++++++++++ lib/user_ptr.c | 26 +++++ 19 files changed, 423 insertions(+), 186 deletions(-) create mode 100644 arch/arm64/include/asm/cheri.h delete mode 100644 arch/arm64/include/asm/user_ptr.h create mode 100644 arch/arm64/include/uapi/asm/cheri.h create mode 100644 include/linux/cheri.h create mode 100644 lib/cheri.c create mode 100644 lib/user_ptr.c
-- 2.38.1
linux-morello mailing list -- linux-morello@op-lists.linaro.org To unsubscribe send an email to linux-morello-leave@op-lists.linaro.org