On 7/18/23 21:13, Tudor Cretu wrote:
Similarly to the previous commits in Morello kselftests, the tag should be: "kselftests/arm64: morello:"
Commits specific for a specific syscall or system, could even have: "kselftests/arm64: morello: mmap:"
I'll change it accordingly.
On 17-07-2023 06:11, Chaitanya S Prakash wrote:
Wrapper functions for system calls that are frequently invoked are added in order to improve ease of usability. Making use of the newly added support, mmap.c can be re-written in a manner that avoids directly interacting with syscalls. Required datatypes and constants have also been defined.
Additionally, dependency required to utilise signal > support has also been added.
Just a suggestion. This patch adds necessary support for mmap testcases, but doesn't specify what kind of testcases need this kind of support. The added dependency to utilise signal support looks a bit unrelated to creating the wrapper functions for syscalls. I would say leave this patch with only creating the wrapper functions, change the commit title to say specifically what the patch does (i.e. create wrapper functions for frequently invoked syscalls), optionally use the wrapper functions created in all the Morello kselftests (not only mmap.c), and move the dependency to the signal support to the patch that uses the signal support, which is "Add mmap() bounds check testcases" AFAICT.
Tudor
I see how that would be a lot clearer, I'll make the changes.
Signed-off-by: Chaitanya S Prakash chaitanyas.prakash@arm.com
.../testing/selftests/arm64/morello/Makefile | 1 + .../selftests/arm64/morello/freestanding.h | 62 ++++++++++++++++++- tools/testing/selftests/arm64/morello/mmap.c | 11 ++-- 3 files changed, 67 insertions(+), 7 deletions(-)