On Wed, Feb 01, 2023 at 05:35:32PM +0000, Teo Couprie Diaz wrote:
test_ioctl calls functions from the shell test framework but does not source it. For unexplained reasons this works on a regular LTP build, but not ours. Source the framework to be able to successfully complete.
It's not entirely unexpected a we deliberately select which targets are being build (and we have made explicit changes to the build.sh script to enable just that, see: 35cda2b9 "build.sh: Allow specifying make targets". Regular LTP builds (regular as upstream CI builds, they do not have that change and they build all that has either been enabled through config step or is otherwise a default make target). I'd rather fix the build script/framework instead, as there might be some other, yet to be discovered dependencies. And speaking on dependencies, it would be good if the tests that do really on that framework made it explicit and either pull it as make target or raise a warning that one is not made available. On that note, if we are to update the build steps for Morello LTP variant, an update to projects README would eb very much appreciated :).
--- BR B.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
NB: This needs a change to the build script used for LTP fix the failure. Indeed, the build framework is in the testcases/lib target which we do not build by default, thus not making the framework available anyway. testcases/kernel/syscalls/ioctl/test_ioctl | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/testcases/kernel/syscalls/ioctl/test_ioctl b/testcases/kernel/syscalls/ioctl/test_ioctl index 923275433..cf960dd35 100755 --- a/testcases/kernel/syscalls/ioctl/test_ioctl +++ b/testcases/kernel/syscalls/ioctl/test_ioctl @@ -23,6 +23,8 @@ export TCID=ioctl01_02 export TST_TOTAL=2 export TST_COUNT=0 +. test.sh
has_tty() { if command -v stty >/dev/null 2>&1; then -- 2.25.1
linux-morello-ltp mailing list -- linux-morello-ltp@op-lists.linaro.org To unsubscribe send an email to linux-morello-ltp-leave@op-lists.linaro.org