On Thu, Oct 14, 2021 at 1:00 PM Viresh Kumar viresh.kumar@linaro.org wrote:
This patch adds support for interrupts to the virtio-gpio specification. This uses the feature bit 0 for the same.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/114 Cc: Marc Zyngier maz@kernel.org Cc: Thomas Gleixner tglx@linutronix.de Reviewed-by: Linus Walleij linus.walleij@linaro.org Signed-off-by: Viresh Kumar viresh.kumar@linaro.org
V9 -> V10:
Mandatory for the interrupt to be enabled before being unmasked.
Remove unnecessary stuff from Device Initialization and clean it up.
Minor cleanup (s/enabled/negotiated, etc).
With the latest changes, this all looks good to me, and I've had another look at the kernel driver you posted last time to make sure I don't see any substantial problems with that either.
I found a few things that can be improved in the driver (as discussed on IRC), but none of those are relevant to the specification update.
Reviewed-by: Arnd Bergmann arnd@arndb.de