On 09.08.22 08:34, Viresh Kumar wrote:
Hello Viresh
make_virtio_mmio_node() creates the DT node for simple MMIO devices currently, i.e. the ones that don't require any additional properties.
In order to allow using it for other complex device types, split the functionality into two, one where the fdt node isn't closed and the other one to create a simple DT node.
Signed-off-by: Viresh Kumar viresh.kumar@linaro.org
tools/libs/light/libxl_arm.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 4a750852b671..891cb6ef2674 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -899,9 +899,8 @@ static int make_xen_iommu_node(libxl__gc *gc, void *fdt) return 0; } -static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
uint64_t base, uint32_t irq,uint32_t backend_domid)+static int make_virtio_mmio_node_common(libxl__gc *gc, void *fdt, uint64_t base,
uint32_t irq, uint32_t backend_domid)
Nit: I would probably add a comment on top of this function that fdt node isn't completed (closed) after the function returns,
so the caller should take care of completing it.
{ int res; gic_interrupt intr; @@ -934,10 +933,18 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, if (res) return res; }
- res = fdt_end_node(fdt);
- return res;
+}
+static int make_virtio_mmio_node_simple(libxl__gc *gc, void *fdt, uint64_t base,
uint32_t irq, uint32_t backend_domid)+{
- int res;
- res = make_virtio_mmio_node_common(gc, fdt, base, irq, backend_domid); if (res) return res;
- return 0;
- return fdt_end_node(fdt); }
static const struct arch_info *get_arch_info(libxl__gc *gc, @@ -1260,8 +1267,8 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, iommu_created = true; }
FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq,disk->backend_domid) );
FDT( make_virtio_mmio_node_simple(gc, fdt, disk->base,disk->irq, disk->backend_domid) );
Nit: Something wrong with the indentation
} }
Preferably with above fixed:
Reviewed-by: Oleksandr Tyshchenko oleksandr_tyshchenko@epam.com