Re: [Stratos-dev] [RFC PATCH 12/15] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub

Philippe Mathieu-Daudé philmd@redhat.com writes:

On 11/5/20 6:51 PM, Alex Bennée wrote:

...

We should never build something that calls this without having it.

"because ..."?

xen-all.c is only built when we have CONFIG_XEN which also gates the only call-site in xen-console.c

Reviewed-by: Philippe Mathieu-Daudé philmd@redhat.com

...

Signed-off-by: Alex Bennée alex.bennee@linaro.org

stubs/xen-hw-stub.c | 4 ---- 1 file changed, 4 deletions(-)

diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 2ea8190921..15f3921a76 100644 --- a/stubs/xen-hw-stub.c +++ b/stubs/xen-hw-stub.c @@ -10,10 +10,6 @@ #include "hw/xen/xen.h" #include "hw/xen/xen-x86.h" -void xenstore_store_pv_console_info(int i, Chardev *chr) -{ -}

int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) { return -1;