Syscalls provided by CONFIG_COMPAT_32BIT_TIME are not required in 64-bit compat. Only enable this option by default if CONFIG_COMPAT32 is selected.
Note that this is a non-functional change on arm64 as since commit "arm64: compat: handle time in compat64 syscalls", syscall handlers provided by CONFIG_COMPAT_32BIT_TIME are unused in compat64.
Signed-off-by: Kevin Brodsky kevin.brodsky@arm.com --- I discovered this by chance when looking at Tudor's AIO patches, as some AIO syscalls have such 32-bit time variants. This patch makes things slightly more consistent and avoids including syscall handlers that end up completely unused in compat64.
Kevin
arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/Kconfig b/arch/Kconfig index 143825c4d3af..e0b819abd16c 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -1137,7 +1137,7 @@ config COMPAT_OLD_SIGACTION
config COMPAT_32BIT_TIME bool "Provide system calls for 32-bit time_t" - default !64BIT || COMPAT + default !64BIT || COMPAT32 help This enables 32 bit time_t support in addition to 64 bit time_t support. This is relevant on all 32-bit architectures, and 64-bit architectures
On 14/06/2023 14:37, Kevin Brodsky wrote:
Syscalls provided by CONFIG_COMPAT_32BIT_TIME are not required in 64-bit compat. Only enable this option by default if CONFIG_COMPAT32 is selected.
Note that this is a non-functional change on arm64 as since commit "arm64: compat: handle time in compat64 syscalls", syscall handlers provided by CONFIG_COMPAT_32BIT_TIME are unused in compat64.
Signed-off-by: Kevin Brodsky kevin.brodsky@arm.com
I discovered this by chance when looking at Tudor's AIO patches, as some AIO syscalls have such 32-bit time variants. This patch makes things slightly more consistent and avoids including syscall handlers that end up completely unused in compat64.
Makes sense.
Reviewed-by: Zachary Leaf zachary.leaf@arm.com
Kevin
arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/Kconfig b/arch/Kconfig index 143825c4d3af..e0b819abd16c 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -1137,7 +1137,7 @@ config COMPAT_OLD_SIGACTION config COMPAT_32BIT_TIME bool "Provide system calls for 32-bit time_t"
- default !64BIT || COMPAT
- default !64BIT || COMPAT32 help This enables 32 bit time_t support in addition to 64 bit time_t support. This is relevant on all 32-bit architectures, and 64-bit architectures
On 23/06/2023 14:30, Zachary Leaf wrote:
On 14/06/2023 14:37, Kevin Brodsky wrote:
Syscalls provided by CONFIG_COMPAT_32BIT_TIME are not required in 64-bit compat. Only enable this option by default if CONFIG_COMPAT32 is selected.
Note that this is a non-functional change on arm64 as since commit "arm64: compat: handle time in compat64 syscalls", syscall handlers provided by CONFIG_COMPAT_32BIT_TIME are unused in compat64.
Signed-off-by: Kevin Brodsky kevin.brodsky@arm.com
I discovered this by chance when looking at Tudor's AIO patches, as some AIO syscalls have such 32-bit time variants. This patch makes things slightly more consistent and avoids including syscall handlers that end up completely unused in compat64.
Makes sense.
Reviewed-by: Zachary Leaf zachary.leaf@arm.com
Thanks for the review, now in next.
Kevin
Kevin
arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/Kconfig b/arch/Kconfig index 143825c4d3af..e0b819abd16c 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -1137,7 +1137,7 @@ config COMPAT_OLD_SIGACTION config COMPAT_32BIT_TIME bool "Provide system calls for 32-bit time_t"
- default !64BIT || COMPAT
- default !64BIT || COMPAT32 help This enables 32 bit time_t support in addition to 64 bit time_t support. This is relevant on all 32-bit architectures, and 64-bit architectures
linux-morello@op-lists.linaro.org
-
Kevin Brodsky -
Zachary Leaf