Re: [PATCH] tee: change type 'unsigned long' to 'user_uintptr_t' in 'tee_ioctl' function
Hi Menna,
Please always keep the list in copy for any communication.
On 7/12/23 14:32, Menna Mahmoud wrote:
Hi Vincenzo,
On Wed, 12 Jul 2023 at 16:24, Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
On 7/12/23 14:01, Menna Mahmoud wrote:
Where fvp.dtb exists? , I couldn't find it.
Is the dtb file you are generating to with the kernel compilation. You need to copy it over and *rename* it as fvp.dtb.
Sorry for disturbing, but which one:
menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts$ ls actions amlogic broadcom intel microchip renesas tesla allwinner apm cavium lg nuvoton rockchip ti altera apple exynos Makefile nvidia socionext toshiba amazon arm freescale marvell qcom sprd xilinx amd bitmain hisilicon mediatek realtek synaptics menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts$ cd arm menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts/arm$ ls corstone1000.dtsi foundation-v8-gicv3.dtb fvp-base-revc.dtb juno-r1.dts juno-scmi.dtsi corstone1000-fvp.dtb foundation-v8-gicv3.dts fvp-base-revc.dts juno-r1-scmi.dtb Makefile corstone1000-fvp.dts foundation-v8-gicv3.dtsi juno-base.dtsi juno-r1-scmi.dts rtsm_ve-aemv8a.dtb corstone1000-mps3.dtb foundation-v8-gicv3-psci.dtb juno-clocks.dtsi juno-r2.dtb rtsm_ve-aemv8a.dts corstone1000-mps3.dts foundation-v8-gicv3-psci.dts juno-cs-r1r2.dtsi juno-r2.dts rtsm_ve-motherboard.dtsi foundation-v8.dtb foundation-v8-psci.dtb juno.dtb juno-r2-scmi.dtb rtsm_ve-motherboard-rs2.dtsi foundation-v8.dts foundation-v8-psci.dts juno.dts juno-r2-scmi.dts vexpress-v2f-1xv7-ca53x2.dtb foundation-v8.dtsi foundation-v8-psci.dtsi juno-motherboard.dtsi juno-scmi.dtb vexpress-v2f-1xv7-ca53x2.dts foundation-v8-gicv2.dtsi foundation-v8-spin-table.dtsi juno-r1.dtb juno-scmi.dts vexpress-v2m-rs1.dtsi menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts/arm$
This is not the morello kernel you compiled with the OPTEE fixes. That kernel should have a "morello-fvp.dtb" which you need to rename into "fvp.dtb".
Thanks.
-- Regards, Vincenzo
Hi Vincenzo,
On Wed, 12 Jul 2023 at 16:51, Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
Please always keep the list in copy for any communication.
Sorry, I missed it.
On 7/12/23 14:32, Menna Mahmoud wrote:
Hi Vincenzo,
On Wed, 12 Jul 2023 at 16:24, Vincenzo Frascino <
vincenzo.frascino@arm.com>
wrote:
Hi Menna,
On 7/12/23 14:01, Menna Mahmoud wrote:
Where fvp.dtb exists? , I couldn't find it.
Is the dtb file you are generating to with the kernel compilation. You need to copy it over and *rename* it as fvp.dtb.
Sorry for disturbing, but which one:
menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts$ ls actions amlogic broadcom intel microchip renesas tesla allwinner apm cavium lg nuvoton rockchip ti altera apple exynos Makefile nvidia socionext toshiba amazon arm freescale marvell qcom sprd xilinx amd bitmain hisilicon mediatek realtek synaptics menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts$ cd arm menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts/arm$ ls corstone1000.dtsi foundation-v8-gicv3.dtbfvp-base-revc.dtb
juno-r1.dts juno-scmi.dtsicorstone1000-fvp.dtb foundation-v8-gicv3.dts
fvp-base-revc.dts
juno-r1-scmi.dtb Makefilecorstone1000-fvp.dts foundation-v8-gicv3.dtsi juno-base.dtsi juno-r1-scmi.dts rtsm_ve-aemv8a.dtb corstone1000-mps3.dtb foundation-v8-gicv3-psci.dtb juno-clocks.dtsi juno-r2.dtb rtsm_ve-aemv8a.dts corstone1000-mps3.dts foundation-v8-gicv3-psci.dts
juno-cs-r1r2.dtsi
juno-r2.dts rtsm_ve-motherboard.dtsifoundation-v8.dtb foundation-v8-psci.dtb juno.dtb juno-r2-scmi.dtb rtsm_ve-motherboard-rs2.dtsi foundation-v8.dts foundation-v8-psci.dts juno.dts juno-r2-scmi.dts vexpress-v2f-1xv7-ca53x2.dtb foundation-v8.dtsi foundation-v8-psci.dtsi juno-motherboard.dtsi juno-scmi.dtb vexpress-v2f-1xv7-ca53x2.dts foundation-v8-gicv2.dtsi foundation-v8-spin-table.dtsi juno-r1.dtb juno-scmi.dts vexpress-v2m-rs1.dtsi menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts/arm$
This is not the morello kernel you compiled with the OPTEE fixes. That kernel should have a "morello-fvp.dtb" which you need to rename into "fvp.dtb".
Okay, I'll check it.
Thanks, Menna
Thanks.
-- Regards, Vincenzo
-- Regards, Vincenzo
Hi Vincenzo,
On Wed, 12 Jul 2023 at 16:54, Menna Mahmoud eng.mennamahmoud.mm@gmail.com wrote:
Hi Vincenzo,
On Wed, 12 Jul 2023 at 16:51, Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
Please always keep the list in copy for any communication.
Sorry, I missed it.
On 7/12/23 14:32, Menna Mahmoud wrote:
Hi Vincenzo,
On Wed, 12 Jul 2023 at 16:24, Vincenzo Frascino <
vincenzo.frascino@arm.com>
wrote:
Hi Menna,
On 7/12/23 14:01, Menna Mahmoud wrote:
Where fvp.dtb exists? , I couldn't find it.
Is the dtb file you are generating to with the kernel compilation. You need to copy it over and *rename* it as fvp.dtb.
Sorry for disturbing, but which one:
menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts$ ls actions amlogic broadcom intel microchip renesas tesla allwinner apm cavium lg nuvoton rockchip ti altera apple exynos Makefile nvidia socionext toshiba amazon arm freescale marvell qcom sprd xilinx amd bitmain hisilicon mediatek realtek synaptics menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts$ cd arm menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts/arm$ ls corstone1000.dtsi foundation-v8-gicv3.dtbfvp-base-revc.dtb
juno-r1.dts juno-scmi.dtsicorstone1000-fvp.dtb foundation-v8-gicv3.dts
fvp-base-revc.dts
juno-r1-scmi.dtb Makefilecorstone1000-fvp.dts foundation-v8-gicv3.dtsi juno-base.dtsi juno-r1-scmi.dts rtsm_ve-aemv8a.dtb corstone1000-mps3.dtb foundation-v8-gicv3-psci.dtb
juno-clocks.dtsi
juno-r2.dtb rtsm_ve-aemv8a.dtscorstone1000-mps3.dts foundation-v8-gicv3-psci.dts
juno-cs-r1r2.dtsi
juno-r2.dts rtsm_ve-motherboard.dtsifoundation-v8.dtb foundation-v8-psci.dtb juno.dtb juno-r2-scmi.dtb rtsm_ve-motherboard-rs2.dtsi foundation-v8.dts foundation-v8-psci.dts juno.dts juno-r2-scmi.dts vexpress-v2f-1xv7-ca53x2.dtb foundation-v8.dtsi foundation-v8-psci.dtsi juno-motherboard.dtsi juno-scmi.dtb vexpress-v2f-1xv7-ca53x2.dts foundation-v8-gicv2.dtsi foundation-v8-spin-table.dtsi juno-r1.dtb juno-scmi.dts vexpress-v2m-rs1.dtsi menna@menna:~/Desktop/optee-project/linux/arch/arm64/boot/dts/arm$
This is not the morello kernel you compiled with the OPTEE fixes. That kernel should have a "morello-fvp.dtb" which you need to rename into "fvp.dtb".
I found this file `morello-fvp.dts` only, couldn't find .dtb.
Regards, Menna
Okay, I'll check it.
Thanks, Menna
Thanks.
-- Regards, Vincenzo
-- Regards, Vincenzo
Hi Menna,
On 7/12/23 14:58, Menna Mahmoud wrote:
I found this file `morello-fvp.dts` only, couldn't find .dtb.
After you compile the kernel you should have the dtb. Copy it together with the Image file.
Hi Vincenzo,
On Wed, 12 Jul 2023 at 17:21, Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
On 7/12/23 14:58, Menna Mahmoud wrote:
I found this file `morello-fvp.dts` only, couldn't find .dtb.
After you compile the kernel you should have the dtb. Copy it together with the Image file.
I followed this steps as you told me:
``` $ mkdir -p <optee-project> $ cd <optee-project> $ repo init -u https://github.com/OP-TEE/manifest.git -m fvp.xml $ repo sync -j4 --no-clone-bundle
$ cd <optee-project>/build $ make -j2 toolchains
$ mkdir -p <optee-project>/morello $ cd <optee-project>/morello $ wget -O FVP_Morello_0.11_34.tgz https://developer.arm.com/-/media/Arm%20Developer%20Community/Downloads/OSS/. .. $ tar -xzvf FVP_Morello_0.11_34.tgz $ ./FVP_Morello.sh --force --destination ./FVP_Morello ...
Please answer with one of: 'yes' or 'no/quit' Do you agree to the above terms and conditions? yes
$ cd <optee-project> $ git clone https://git.morello-project.org/morello/fvp-firmware.git
Then patch the <optee-project>/build/Makefile
$ cd <optee-project>/build $ make -j `nproc`
$ cd <optee-project>/out $ mkdir -p mnt $ sudo mount -o loop boot-fat.uefi.img mnt/ $ cd mnt
and stuck after this step, after compiling the kernel you mean after this step:` make -j `nproc` `, right? because I have done this step but couldn't find .dtb file..
Thanks, Menna
-- Regards, Vincenzo
Hi Menna,
On 7/12/23 15:36, Menna Mahmoud wrote:
and stuck after this step, after compiling the kernel you mean after this step:` make -j `nproc` `, right? because I have done this step but couldn't find .dtb file..
If you build the kernel as per https://sdk.morello-project.org/docs/linux/ you will find both the files.
The kernel to work *needs* to have you OPTEE patch on top.
Hope this is clear.
Hi Vincenzo,
On Wed, 12 Jul 2023 at 18:08, Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
On 7/12/23 15:36, Menna Mahmoud wrote:
and stuck after this step, after compiling the kernel you mean after
this
step:` make -j `nproc` `, right? because I have done this step but couldn't find .dtb file..
If you build the kernel as per https://sdk.morello-project.org/docs/linux/ you will find both the files.
The kernel to work *needs* to have you OPTEE patch on top.
Hope this is clear.
yes, It is clear now, thank you.
Best Regards, Menna
-- Regards, Vincenzo
Hi Vincenzo,
On Wed, 12 Jul 2023 at 6:24 PM Menna Mahmoud eng.mennamahmoud.mm@gmail.com wrote:
Hi Vincenzo,
On Wed, 12 Jul 2023 at 18:08, Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
On 7/12/23 15:36, Menna Mahmoud wrote:
and stuck after this step, after compiling the kernel you mean after
this
step:` make -j `nproc` `, right? because I have done this step but couldn't find .dtb file..
If you build the kernel as per https://sdk.morello-project.org/docs/linux/ you will find both the files.
The kernel to work *needs* to have you OPTEE patch on top.
Hope this is clear.
yes, It is clear now, thank you.
Best Regards, Menna
-- Regards, Vincenzo
I want to check with you some points, First after following all steps you sent , It works fine but the grub menu has OPTEE only, Is it right? also, when running xtest command it failed, and when I ran ‘uname -ra’ I got Optee kernel name, is it right or should I get the morello kernel name?
Regards, Menna
Hi Menna,
On 16/07/2023 12:26, Menna Mahmoud wrote:
Hi Vincenzo,
On Wed, 12 Jul 2023 at 6:24 PM Menna Mahmoud eng.mennamahmoud.mm@gmail.com wrote:
Hi Vincenzo,
On Wed, 12 Jul 2023 at 18:08, Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
On 7/12/23 15:36, Menna Mahmoud wrote:
and stuck after this step, after compiling the kernel you mean after
this
step:` make -j `nproc` `, right? because I have done this step but couldn't find .dtb file..
If you build the kernel as per https://sdk.morello-project.org/docs/linux/ you will find both the files.
The kernel to work *needs* to have you OPTEE patch on top.
Hope this is clear.
yes, It is clear now, thank you.
Best Regards, Menna
-- Regards, Vincenzo
I want to check with you some points, First after following all steps you sent , It works fine but the grub menu has OPTEE only, Is it right? also, when running xtest command it failed, and when I ran ‘uname -ra’ I got Optee kernel name, is it right or should I get the morello kernel name?
Did you replace the Image file?
Just to be clear: the provenance of the Image file needs to be the kernel you are building with the OPTEE patch you sent for review on top.
Can you please tell me what 'uname -a' shows?
Thanks, Vincenzo
Regards, Menna
Hi Vincenzo,
On Mon, 17 Jul 2023 at 15:35, Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
On 16/07/2023 12:26, Menna Mahmoud wrote:
Hi Vincenzo,
On Wed, 12 Jul 2023 at 6:24 PM Menna Mahmoud <
eng.mennamahmoud.mm@gmail.com>
wrote:
Hi Vincenzo,
On Wed, 12 Jul 2023 at 18:08, Vincenzo Frascino <
vincenzo.frascino@arm.com>
wrote:
Hi Menna,
On 7/12/23 15:36, Menna Mahmoud wrote:
and stuck after this step, after compiling the kernel you mean after
this
step:` make -j `nproc` `, right? because I have done this step but couldn't find .dtb file..
If you build the kernel as per https://sdk.morello-project.org/docs/linux/ you will find both the files.
The kernel to work *needs* to have you OPTEE patch on top.
Hope this is clear.
yes, It is clear now, thank you.
Best Regards, Menna
-- Regards, Vincenzo
I want to check with you some points, First after following all steps you sent , It works fine but the grub menu has OPTEE only, Is it right? also, when running xtest command it failed, and when I ran ‘uname -ra’ I got Optee kernel name, is it right or should I get the morello kernel
name?
Did you replace the Image file?
yes, I added this image: linux-out/arch/arm64/boot/Image
Just to be clear: the provenance of the Image file needs to be the kernel you are building with the OPTEE patch you sent for review on top.
yes, I am sure form that.
Can you please tell me what 'uname -a' shows?
here you are the output: https://paste.pics/OT6A1
Thanks, Vincenzo
Regards, Menna
-- Regards, Vincenzo
Thanks, Menna
Hi Menna,
[...]
Can you please tell me what 'uname -a' shows?
here you are the output: https://paste.pics/OT6A1
This is not the signature of our kernel hence you are not booting the Image that you are building from our tree. Please make sure that you replace the default one.
Thanks, Vincenzo
Thanks, Vincenzo
Regards, Menna
-- Regards, Vincenzo
Thanks, Menna
Hi Vincenzo
On Wed, 19 Jul 2023 at 3:44 PM Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
[...]
Can you please tell me what 'uname -a' shows?
here you are the output: https://paste.pics/OT6A1
This is not the signature of our kernel hence you are not booting the Image that you are building from our tree. Please make sure that you replace the default one.
now, the morello image ran but `xtest` failed.
Thanks, Menna
Thanks, Vincenzo
Thanks, Vincenzo
Regards, Menna
-- Regards, Vincenzo
Thanks, Menna
-- Regards, Vincenzo
Hi Vincenzo,
I tried to figure out why the `xtest` failed and found it is related to optee enabling like this issue: https://github.com/OP-TEE/optee_os/issues/3055
Do you have any idea about this?
another question please, when `make -j2 toolchains` I got nothing: ``` ~/optee-project2/build$ make -j2 toolchains ~/optee-project2/build$ ``` Is it right?
Thanks in advance, Menna
On Thu, 20 Jul 2023 at 22:38, Menna Mahmoud eng.mennamahmoud.mm@gmail.com wrote:
Hi Vincenzo
On Wed, 19 Jul 2023 at 3:44 PM Vincenzo Frascino < vincenzo.frascino@arm.com> wrote:
Hi Menna,
[...]
Can you please tell me what 'uname -a' shows?
here you are the output: https://paste.pics/OT6A1
This is not the signature of our kernel hence you are not booting the Image that you are building from our tree. Please make sure that you replace the default one.
now, the morello image ran but `xtest` failed.
Thanks, Menna
Thanks, Vincenzo
Thanks, Vincenzo
Regards, Menna
>
-- Regards, Vincenzo
Thanks, Menna
-- Regards, Vincenzo
Hi Menna,
On 8/15/23 15:42, Menna Mahmoud wrote:
Hi Vincenzo,
I tried to figure out why the `xtest` failed and found it is related to optee enabling like this issue: https://github.com/OP-TEE/optee_os/issues/3055
Do you have any idea about this?
No, sorry. This requires further debugging on your side and it is part of the enablement.
another question please, when `make -j2 toolchains` I got nothing:
~/optee-project2/build$ make -j2 toolchains ~/optee-project2/build$Is it right?
It does not seem so... not sure what you are trying to do. Can you please explain it?
Thanks, Vincenzo
Thanks in advance, Menna
On Thu, 20 Jul 2023 at 22:38, Menna Mahmoud eng.mennamahmoud.mm@gmail.com wrote:
Hi Vincenzo
On Wed, 19 Jul 2023 at 3:44 PM Vincenzo Frascino < vincenzo.frascino@arm.com> wrote:
Hi Menna,
[...]
Can you please tell me what 'uname -a' shows?
here you are the output: https://paste.pics/OT6A1
This is not the signature of our kernel hence you are not booting the Image that you are building from our tree. Please make sure that you replace the default one.
now, the morello image ran but `xtest` failed.
Thanks, Menna
Thanks, Vincenzo
Thanks, Vincenzo
Regards, Menna
> >>
-- Regards, Vincenzo
Thanks, Menna
-- Regards, Vincenzo
On Thu, 17 Aug 2023 at 1:45 PM Vincenzo Frascino vincenzo.frascino@arm.com wrote:
Hi Menna,
On 8/15/23 15:42, Menna Mahmoud wrote:
Hi Vincenzo,
I tried to figure out why the `xtest` failed and found it is related to optee enabling like this issue: https://github.com/OP-TEE/optee_os/issues/3055
Do you have any idea about this?
No, sorry. This requires further debugging on your side and it is part of the enablement.
I will try, Thank you.
another question please, when `make -j2 toolchains` I got nothing:
~/optee-project2/build$ make -j2 toolchains ~/optee-project2/build$Is it right?
It does not seem so... not sure what you are trying to do. Can you please explain it?
I figured it out, Thanks for your help.
Best regards, Menna
Thanks, Vincenzo
Thanks in advance, Menna
On Thu, 20 Jul 2023 at 22:38, Menna Mahmoud <
eng.mennamahmoud.mm@gmail.com>
wrote:
Hi Vincenzo
On Wed, 19 Jul 2023 at 3:44 PM Vincenzo Frascino < vincenzo.frascino@arm.com> wrote:
Hi Menna,
[...]
Can you please tell me what 'uname -a' shows?
here you are the output: https://paste.pics/OT6A1
This is not the signature of our kernel hence you are not booting the Image that you are building from our tree. Please make sure that you replace the default one.
now, the morello image ran but `xtest` failed.
Thanks, Menna
Thanks, Vincenzo
Thanks, Vincenzo
> Regards, > Menna > >> >>> >
-- Regards, Vincenzo
Thanks, Menna
-- Regards, Vincenzo
-- Regards, Vincenzo
linux-morello@op-lists.linaro.org
-
Menna Mahmoud -
Vincenzo Frascino