__kernel_uintcap_t is an arm64-specific uapi type, so it does not make sense to use it to define uintcap_t. Besides, uintcap_t is only defined if CHERI is available, so defining it as __uintcap_t directly is perfectly fine.
Fixes: ("linux/types.h: Introduce uintcap_t") Signed-off-by: Kevin Brodsky kevin.brodsky@arm.com --- include/linux/types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/types.h b/include/linux/types.h index e50e886a544f..e5175b9e8831 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -63,7 +63,7 @@ typedef unsigned long ptraddr_t; #endif
#ifdef __CHERI__ -typedef __kernel_uintcap_t uintcap_t; +typedef __uintcap_t uintcap_t; #endif
#ifdef CONFIG_HAVE_UID16
On 31-10-2022 17:07, Kevin Brodsky wrote:
__kernel_uintcap_t is an arm64-specific uapi type, so it does not make sense to use it to define uintcap_t. Besides, uintcap_t is only defined if CHERI is available, so defining it as __uintcap_t directly is perfectly fine.
Fixes: ("linux/types.h: Introduce uintcap_t")
You're missing the SHA-1 ID of the commit. Looks good otherwise!
Thanks, Tudor
Signed-off-by: Kevin Brodsky kevin.brodsky@arm.com
include/linux/types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/types.h b/include/linux/types.h index e50e886a544f..e5175b9e8831 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -63,7 +63,7 @@ typedef unsigned long ptraddr_t; #endif #ifdef __CHERI__ -typedef __kernel_uintcap_t uintcap_t; +typedef __uintcap_t uintcap_t; #endif #ifdef CONFIG_HAVE_UID16
On 16/11/2022 16:57, Tudor Cretu wrote:
On 31-10-2022 17:07, Kevin Brodsky wrote:
__kernel_uintcap_t is an arm64-specific uapi type, so it does not make sense to use it to define uintcap_t. Besides, uintcap_t is only defined if CHERI is available, so defining it as __uintcap_t directly is perfectly fine.
Fixes: ("linux/types.h: Introduce uintcap_t")
You're missing the SHA-1 ID of the commit. Looks good otherwise!
+1
Thanks, Tudor
Signed-off-by: Kevin Brodsky kevin.brodsky@arm.com
include/linux/types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/types.h b/include/linux/types.h index e50e886a544f..e5175b9e8831 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -63,7 +63,7 @@ typedef unsigned long ptraddr_t; #endif #ifdef __CHERI__ -typedef __kernel_uintcap_t uintcap_t; +typedef __uintcap_t uintcap_t; #endif #ifdef CONFIG_HAVE_UID16
linux-morello mailing list -- linux-morello@op-lists.linaro.org To unsubscribe send an email to linux-morello-leave@op-lists.linaro.org
On 16/11/2022 17:57, Tudor Cretu wrote:
On 31-10-2022 17:07, Kevin Brodsky wrote:
__kernel_uintcap_t is an arm64-specific uapi type, so it does not make sense to use it to define uintcap_t. Besides, uintcap_t is only defined if CHERI is available, so defining it as __uintcap_t directly is perfectly fine.
Fixes: ("linux/types.h: Introduce uintcap_t")
You're missing the SHA-1 ID of the commit. Looks good otherwise!
That's on purpose, we have adopted this (admittedly somewhat strange) format to avoid embedding hashes in commit messages, as the hashes change every time we rebase.
Thanks for the review, now applied on next.
Kevin
Thanks, Tudor
Signed-off-by: Kevin Brodsky kevin.brodsky@arm.com
include/linux/types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/types.h b/include/linux/types.h index e50e886a544f..e5175b9e8831 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -63,7 +63,7 @@ typedef unsigned long ptraddr_t; #endif #ifdef __CHERI__ -typedef __kernel_uintcap_t uintcap_t; +typedef __uintcap_t uintcap_t; #endif #ifdef CONFIG_HAVE_UID16
linux-morello@op-lists.linaro.org
-
Kevin Brodsky -
Tudor Cretu -
Zachary Leaf