Oh docker is using the key infra? I didn't know it did.
On 9/2/22 08:08, Vincenzo Frascino wrote:
Hi Carsten,
On 9/1/22 21:03, Carsten Haitzler wrote:
Shouldn't this be a separate patch set as it's not to do with docker?
Without this patch you cannot enable docker successfully, hence I would keep it as part of the same series (for testability of the usecase).
Thanks, Vincenzo
On 9/1/22 09:24, Kevin Brodsky wrote:
I don't think the commit title has much to do with what the commit actually does, maybe something along the lines of "Remove inconsistent __user annotation"?
On 31/08/2022 16:37, Vincenzo Frascino wrote:
With the introduction of capabilities and PCuABI being enabled when dealing with the user pointers does expect a capability.
Address the compilation issues below triggered by otherwise implicit conversion that might lead to unexpected behaviour when operating on capabilities.
make[1]: linux/security/keys/keyring.c:93 error: incompatible function pointer types initializing 'long (*)(const struct key *, char *, size_t)' (aka 'long (*)(const struct key *, char *, unsigned long)') with an expression of type 'long (const struct key *, char * __capability, size_t)' (aka 'long (const struct key *, char * __capability, unsigned long)') [-Werror,-Wincompatible-function-pointer-types] .read = keyring_read,
Note: User defined interface is in separate compilation unit.
Not sure I understand what this last sentence refers to. I think the most useful thing to say in the commit message is that the declaration doesn't match the definition, and the definition is correct (it matches what struct key_type::read expects).
Anyway it's a good finding, can't believe no one has noticed since essentially forever!
Kevin
Signed-off-by: Vincenzo Frascino vincenzo.frascino@arm.com
security/keys/keyring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/keyring.c b/security/keys/keyring.c index 5e6a90760753..4448758f643a 100644 --- a/security/keys/keyring.c +++ b/security/keys/keyring.c @@ -79,7 +79,7 @@ static void keyring_revoke(struct key *keyring); static void keyring_destroy(struct key *keyring); static void keyring_describe(const struct key *keyring, struct seq_file *m); static long keyring_read(const struct key *keyring, - char __user *buffer, size_t buflen); + char *buffer, size_t buflen); struct key_type key_type_keyring = { .name = "keyring",
linux-morello mailing list -- linux-morello@op-lists.linaro.org To unsubscribe send an email to linux-morello-leave@op-lists.linaro.org