Hi Teo,
On 17-10-2022 17:55, Teo Couprie Diaz wrote:
brk should not be implemented in purecap, return -ENOSYS when not in compat.
Wrap the commit description to 75 chars per line.
Co-authored-by: Tudor Cretu tudor.cretu@arm.com
For future references, the correct tag is: Co-Developed-by. I appreciate adding me! In this case, I think it's more appropriate if you remove my name as it's your idea and your testing whereas I merely suggested an alternative, so no need to credit me for it 😉.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
Thanks Tudor for providing the code snippet, making it much more clear than my original ideas.
My pleasure, good job for the patches!
mm/mmap.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/mm/mmap.c b/mm/mmap.c index ce282f9d9f8e..1048c358b872 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -194,6 +194,11 @@ static int do_brk_flags(unsigned long addr, unsigned long request, unsigned long struct list_head *uf); SYSCALL_DEFINE1(brk, unsigned long, brk) { +#ifdef CONFIG_CHERI_PURECAP_UABI
- if (!in_compat_syscall()) {
- return -ENOSYS;
- }
+#endif
The code looks good to me. There are a few formatting nits, use tabs instead of spaces. Make sure to set your tab width to 8 spaces to check if everything aligns nicely as you expected. Also, no need for braces for single-statement blocks. Make sure to use checkpatch if it complains about anything else.
Thanks, Tudor
unsigned long newbrk, oldbrk, origbrk; struct mm_struct *mm = current->mm; struct vm_area_struct *next;