4 Apr
2023
4 Apr
'23
5:08 p.m.
On 04-04-2023 08:06, Kevin Brodsky wrote:
On 29/03/2023 17:11, Tudor Cretu wrote:
+static inline bool io_user_data_is_same(const __kernel_uintptr_t d1,
const __kernel_uintptr_t d2)Nit: there is generally not much point in having const arguments, as the only thing it achieves is preventing the function from modifying what is effectively local variables. Note that this is very different from passing a _pointer to_ const (const T *), because in that case the constness actually prevents the function from modifying data it doesn't own.
Kevin
Oups, forgot to turn my brain on when copy-pasted this. I have removed the const in the next version.
Many thanks for the review!
Tudor