On 13/12/2022 18:06, Teo Couprie Diaz wrote:
void* is used to align to 32-bits or 64-bits on 32 and 64 bits archs.
... respectively.
Purecap breaks this assumption. As struct __kernel_sockaddr_storage is used for both Aarch64 and purecap
We shouldn't talk about AArch64 for generic code, besides it's clear this struct is used regardless of the ABI. I think pointing out that void * has an alignment of 16 in PCuABI would be more helpful.
Kevin
user structs, we cannot reliably use void* for alignment.
Change it to an unsigned long. Musl uses the same type for its definition of struct sockaddr_storage.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
include/uapi/linux/socket.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/socket.h b/include/uapi/linux/socket.h index 51d6bb2f6765..28ff6a4aebca 100644 --- a/include/uapi/linux/socket.h +++ b/include/uapi/linux/socket.h @@ -22,7 +22,7 @@ struct __kernel_sockaddr_storage { /* space to achieve desired size, */ /* _SS_MAXSIZE value minus size of ss_family */ };
void *__align; /* implementation specific desired alignment */
unsigned long __align; /* implementation specific desired alignment */};