[linux-morello] Re: [PATCH 02/12] arch: rename to in_compat32_syscall

On 12/09/2023 11:51, Zachary Leaf wrote:

in_32bit_compat_syscall() + is_32bit_compat_task() were originally named to be consistent with is_32bit_compat_thread() from asm/compat.h in the commit ("arch: add compat helpers specific to 32-bit").

AFAICT it is the other way round: first the generic helpers were introduced, then the arm64-specific is_compat_thread() was renamed [1]. As long as Kristina doesn't see an issue with the renaming, neither do I, but I would prefer the renaming to be complete (all compat32 helpers including the arm64 ones).

Kevin

[1] https://git.morello-project.org/morello/kernel/linux/-/commit/a53b230b237d3c...