On 05/05/2023 17:36, Pawel Zalewski wrote:
This series of patches enables nfs rootfs support on the Morello board.
Patches 01 and 02 fix the inital kernel build error associated with a wrong function pointer type within the sunrpc modules due to the unlocked_ioctl fp, the error occurs upon enabling nfs within the defconfig.
Patches 03-09 deal with the fallout caused by changes inferred by patches 01 and 02. Details can be found in the description of patch 03.
Patch 10 is enabling nfs rootfs by default in the kernel.
It was confirmed that the kernel can boot with a nfs rootfs, the other affected modules were not tested.
Pawel Zalewski (10): net:sunrpc: fix incompatible function pointer type in cache net:sunrpc: fix incompatible function pointer type in rpc_pipe include:linux: proc_ioctl should take user_uintptr_t as argument net:sunrpc: fix incompatible function pointer type in cache sound:core: fix incompatible function pointer type in info scsi:esas2r: fix incompatible function pointer type in esas2r_main pci: fix incompatible function pointer type in proc hwmon: fix incompatible function pointer type in dell-smm-hwmon cpu:mtrr: fix incompatible function pointer type in if defconfig: enable nfs rootfs by default
Thank you for your contribution, very appreciated! Overall the changes look sensible, using user_uintptr_t for ioctl handlers that expect pointers is the right thing to do.
Some general comments regarding commit messages: * Commit messages should be wrapped at 75 columns (or less), see [1]. * There should be a space between tags, e.g. "net: sunrpc:" rather than "net:sunrpc:". * File names are not normally mentioned in the commit title, however it's important to make it clear that it's about ioctl handlers. We could say for instance "fix unlocked_ioctl handler signature".
Regarding specific patches: * Patch 1-2 could be merged as they essentially do the same thing and target the same subsystem. * AFAICT we do not need the following patches because the corresponding subsystems are not part of the Morello defconfig (yet): - Patch 5 (sound is not enabled at all); - Patch 6 (CONFIG_SCSI_ESAS2R is not set); - Patch 8 (HW-specific file that is not relevant to Morello); - Patch 9 (x86 so not relevant to Morello). - Note: in general we avoid modifying files we do not build, as we are then unable to check whether the patch works at all. * Patch 3 will break the build, we try to avoid that for bisectability purposes. The easiest solution is to merge it with patch 4 and 7.
A few more specific comments follow in reply to some patches.
Kevin
[1] https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-...
arch/arm64/configs/morello_transitional_pcuabi_defconfig | 2 ++ arch/x86/kernel/cpu/mtrr/if.c | 2 +- drivers/hwmon/dell-smm-hwmon.c | 2 +- drivers/pci/proc.c | 2 +- drivers/scsi/esas2r/esas2r_main.c | 2 +- include/linux/proc_fs.h | 4 ++-- include/sound/info.h | 2 +- net/sunrpc/cache.c | 6 +++--- net/sunrpc/rpc_pipe.c | 2 +- sound/core/info.c | 2 +- 10 files changed, 14 insertions(+), 12 deletions(-)