On 27/10/2023 12:56, Zachary Leaf wrote:
On 28/09/2023 13:49, Tudor Cretu wrote:
On 26-09-2023 11:02, Zachary Leaf wrote:
+ case BPF_LINK_GET_NEXT_ID: + /* u32 prog_id, map_id, btf_id + link_id are in a union with + * u32 start_id */
nit: checkpatch complains about multi-line comment should have the trailing */ on a separate line. You have one more in PATCH 8. With so many structs and unions, no wonder these 2 comments slipped 😅.
I did notice this, but it's a warning, so like compiler warnings they can be safely ignored (:
To be fair many checkpatch warnings can indeed be ignored - it's not that enlightened, and the warnings are often debatable.
Just kidding - but I think this kind of slight line overrun would look weird with the */ and isn't worth adding an extra line for?
On this particular point though, I think checkpatch is right. The standard format in the kernel is either /* one line */
or
/* * two * lines */
I also find it a bit annoying when a comment overruns a line by just a little, but it is what it is.
Kevin