On 13/07/2023 18:31, Aditya Deshpande wrote:
Just a suggestion, since you've started doing some cleanup in that Makefile to use lib.mk functionalities: I think you should be able to remove this rule, as lib.mk already includes it.
Kevin
$(OUTPUT)/vdso_test_gettimeofday: parse_vdso.c vdso_test_gettimeofday.c $(OUTPUT)/vdso_test_getcpu: parse_vdso.c vdso_test_getcpu.c
Apologies, I'm not quite 100% sure what you mean here. From what I understand, we'd still need these lines due to the dependency on parse_vdso.c for each test binary. I tried removing those lines and the Makefile didn't work. Please let me know if I've missed something.
Sorry, I should probably have clarified that I meant specifically the line that I was replying to (that is "all: $(TEST_GEN_PROGS)").
However, as we explicitly state recipes, we can remove the $(TEST_GEN_PROGS) after the all target like so:
-all: $(TEST_GEN_PROGS) +all:
I think we can remove it altogether. lib.mk already has this rule:
all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
Kevin