11 Apr
2024
11 Apr
'24
7:57 p.m.
On 10/04/2024 21:20, Beata Michalska wrote:
+enum vcpu_cap_sysregs {
- __INVALID_CAP_SYSREG__,
- CTPIDR_EL0,
- RTPIDR_EL0,
RCTPIDR_EL0 to be consistent.
Are all the capability registers expected to be here? If so, DDC_EL0 and RDDC_EL0 are missing.
- CTPIDRRO_EL0,
- CTPIDR_EL1,
- CELR_EL1,
- CVBAR_EL1,
- CSP_EL1,
- DDC_EL1,
- CELR_EL2,
- CVBAR_EL2,
- CTPIDR_EL2,
- CSP_EL2,
- DDC_EL2,
I can't see most of these registers being saved or restored in the current series, is that expected?
Yes, currently the bare minimum is being handled, and the rest is for completeness only, as stated in the commit message (not complete enough as you have pointed out though ...)
That's understood, no expectation of completeness here. I wonder if it makes sense to add those registers to this enum without handling them though, it seems more misleading than helpful.
Kevin