[linux-morello] Re: [PATCH 0/2] Support userspace capabilities for tcp_zerocopy_receive

On 15-09-2023 08:56, Harry Ramsey wrote:

Hello,

This patch series enables purecap applications to utilise tcp_zerocopy_receive to map packets directly from a network interface card into a shared space with the process and kernel.

I have tested these changes against musl and there still exists an issue in this implementation with copybuf and potentially msg_control generating an EFAULT error.

Hi Harry,

Thanks for sending this out! Let us know if you intend to continue debugging it or if you want us to pick it up.

Gitlab Issue:

• https://git.morello-project.org/morello/kernel/linux/-/issues/46

Review branch:

• https://git.morello-project.org/harryramsey/linux/-/commits/tcp_zerocopy

Thanks, Harry

Harry Ramsey (2): tcp: Support userspace capabilities for tcp_zerocopy_receive tcp: Implement compat version of tcp_zerocopy_receive

The order of the commits should be reversed, so that the plain AArch64 apps are still working after every commit.

A great series, well done! Just a few nits and comments.

Many thanks, Tudor

include/linux/sockptr.h | 28 ++++++++++ include/uapi/linux/tcp.h | 27 +++++++--- net/ipv4/tcp.c | 111 +++++++++++++++++++++++++++++++++------ 3 files changed, 145 insertions(+), 21 deletions(-)