On 22-09-2023 14:16, Vincenzo Frascino wrote:
Hi Tudor,
Hi Vincenzo,
On 9/22/23 13:07, Tudor Cretu wrote:
Next version of Harry's tcp_zerocopy_receive series. It aims to enable purecap applications to utilise tcp_zerocopy_receive to map packets directly from a network interface card into a shared space with the process and kernel.
Something worth noticing in this case is that you should maintain the original author and Sign-off (as per v2) and then add "Co-developed-by:" with your tag and "Signed-off-by:". This helps keeping the history of the patches and it is the way in which it is handled upstream.
e.g.:
--->8---
Author: Harry Ramsey harry.ramsey@arm.com
[...]
Signed-off-by: Harry Ramsey harry.ramsey@arm.com Co-developed-by: Tudor Cretu tudor.cretu@arm.com Signed-off-by: Tudor Cretu tudor.cretu@arm.com
--->8---
Please refer to [1] for further details.
The individual patches do have the format referred in [1]. If you're referring about the cover letter, this cover letter is from me, so it didn't make sense to me to use the tags here. Furthermore, the series diff at the end of this cover letter credits Harry as the author as expected.
The only case in which you become author of a patch in a pre-existing series is if you add the patch ex novo.
[1] https://docs.kernel.org/process/submitting-patches.html#:~:text=Co%2Ddevelop....
v2..v3:
- Fix the split between compat enablement and capability support
- Reorganise comments in struct tcp_zerocopy_receive
- Fix the order of arguments for the *_to_sockptr functions
- Change a few variables to user_uintptr_t as they were originally unsigned long
- Remove unnecessary checks
- Fix cast warnings
- Add compat handling for offsetofend
- Move a check_user_ptr closer to where its metadata is dropped
- Format misc nits
Gitlab Issue: https://git.morello-project.org/morello/kernel/linux/-/issues/46
Review branch: https://git.morello-project.org/tudcre01/linux/-/commits/morello/tcp_v3
Cc: Harry Ramsey harry.ramsey@arm.com
Harry Ramsey (2): tcp: Implement compat handling for struct tcp_zerocopy_receive tcp: Support capabilities in tcp_zerocopy_receive
include/linux/sockptr.h | 28 +++++++ include/uapi/linux/tcp.h | 10 +-- net/ipv4/tcp.c | 157 +++++++++++++++++++++++++++++++-------- 3 files changed, 157 insertions(+), 38 deletions(-)