On 05/06/2023 17:46, Luca Vizzarro wrote:
The prototype of io_uring_cmd_import_fixed has been updated to support PCuABI. This function is used in the nvme module which currently does not support PCuABI.
Signed-off-by: Luca Vizzarro Luca.Vizzarro@arm.com
drivers/nvme/host/ioctl.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c index 81f5550b670d..0589403368b6 100644 --- a/drivers/nvme/host/ioctl.c +++ b/drivers/nvme/host/ioctl.c @@ -101,6 +101,7 @@ static int nvme_map_user_request(struct request *req, u64 ubuffer, /* fixedbufs is only for non-vectored io */ if (WARN_ON_ONCE(vec)) return -EINVAL;
/* TODO [PCuABI]: change ubuffer type to user_uintptr_t */
Makes sense to add such TODO for drivers we don't build yet, I like the idea. It would not be that useful if the prototype still used user_uintptr_t, as the compiler would then still happy accept an unsigned long, but if that function is also modified to take a void __user * like io_import_fixed() (see my comment in patch 7) then we'll get a compiler error and that TODO will help.
Kevin
ret = io_uring_cmd_import_fixed(ubuffer, bufflen, rq_data_dir(req), &iter, ioucmd); if (ret < 0)