On 02/02/2023 17:06, Luca Vizzarro wrote:
Hi all,
This patch series addresses the issue reported in the following issue: https://git.morello-project.org/morello/kernel/linux/-/issues/42
Changes available at: https://git.morello-project.org/Sevenarth/linux/-/commits/morello/6.1-fix-fc...
v3:
- move the explicit cast change before updating the interfaces
- fix typos
v2:
- added a new argi variable which performs explicit int casting
- updated all of the commands with int argument to use argi explicitly
- updated signatures for the abstract generic_setlease and vfs_setlease with int argument
Luca Vizzarro (4): fs/fcntl: Cast commands with int args explicitly fs/fcntl: Fix F_SETLEASE helper functions fs/fcntl: Fix F_SETPIPE_SZ helper functions fs/fcntl: Fix F_ADD_SEALS helper functions
The tags should correspond to the files they are touching, trying to match commits upstream. I'd suggest respectively "fnctl:", "fs:", "pipe:" and "memfd:".
It would also be nice to be more "functional" in these commit titles, you can't be very specific in so few characters but just "Fix" gives no idea about the nature of the issue. Maybe something along the lines of "interpreting/passing arg as int" would help. Happy to try and give more specific suggestions if needed.
The changes look good to me otherwise (with a few comments on patch 1), this is the most thorough approach possible.
Kevin
fs/cifs/cifsfs.c | 2 +- fs/fcntl.c | 23 ++++++++++++----------- fs/libfs.c | 2 +- fs/locks.c | 22 +++++++++++----------- fs/nfs/nfs4file.c | 2 +- fs/nfs/nfs4proc.c | 4 ++-- fs/pipe.c | 6 +++--- include/linux/fs.h | 16 ++++++++-------- include/linux/memfd.h | 4 ++-- include/linux/pipe_fs_i.h | 4 ++-- mm/memfd.c | 6 +----- 11 files changed, 44 insertions(+), 47 deletions(-)