setpgid02 was changed upstream in commit f2797fa44893 ("setpgid02: Convert to new LTP API") and now assumes that LTP runs in a different session from init (PID 1) for the EPERM test case. This breaks in our CI as the busybox rootfs runs sh as PID 1.
Skip the EPERM test case for the morello release 1.6.0 while waiting for a fix to be decided with upstream. This mostly doesn't impact test coverage as EPERM is also tested for in setpgid03.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com --- testcases/kernel/syscalls/setpgid/setpgid02.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/setpgid/setpgid02.c b/testcases/kernel/syscalls/setpgid/setpgid02.c index 4b63afee8..4dcb7613d 100644 --- a/testcases/kernel/syscalls/setpgid/setpgid02.c +++ b/testcases/kernel/syscalls/setpgid/setpgid02.c @@ -31,7 +31,12 @@ static struct tcase { } tcases[] = { {&pid, &negative_pid, EINVAL}, {&ppid, &pgid, ESRCH}, - {&pid, &init_pgid, EPERM} + /* + * FIXME: This test case makes an assumption that is invalid in our CI. + * Skip it for now as the error case is covered in setpgid03 anyway. + * Should be restored when the fix is decided with upstream. + */ +/* {&pid, &init_pgid, EPERM} */ };
static void setup(void)
Now on morello/master and morello/next. morello-release-1.6.0 tag has been moved has well.
Thanks everyone !
On 12/04/2023 11:23, Teo Couprie Diaz wrote:
setpgid02 was changed upstream in commit f2797fa44893 ("setpgid02: Convert to new LTP API") and now assumes that LTP runs in a different session from init (PID 1) for the EPERM test case. This breaks in our CI as the busybox rootfs runs sh as PID 1.
Skip the EPERM test case for the morello release 1.6.0 while waiting for a fix to be decided with upstream. This mostly doesn't impact test coverage as EPERM is also tested for in setpgid03.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
testcases/kernel/syscalls/setpgid/setpgid02.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/setpgid/setpgid02.c b/testcases/kernel/syscalls/setpgid/setpgid02.c index 4b63afee8..4dcb7613d 100644 --- a/testcases/kernel/syscalls/setpgid/setpgid02.c +++ b/testcases/kernel/syscalls/setpgid/setpgid02.c @@ -31,7 +31,12 @@ static struct tcase { } tcases[] = { {&pid, &negative_pid, EINVAL}, {&ppid, &pgid, ESRCH},
- {&pid, &init_pgid, EPERM}
- /*
* FIXME: This test case makes an assumption that is invalid in our CI.* Skip it for now as the error case is covered in setpgid03 anyway.* Should be restored when the fix is decided with upstream.*/+/* {&pid, &init_pgid, EPERM} */ }; static void setup(void)
linux-morello-ltp@op-lists.linaro.org
-
Teo Couprie Diaz