setpgid02 was changed upstream in commit f2797fa44893 ("setpgid02: Convert to new LTP API") and now assumes that LTP runs in a different session from init (PID 1). This breaks in our CI as the busybox rootfs runs sh as PID 1.
Don't run this test in CI for the morello release 1.6.0 while waiting for a fix to be decided with upstream.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com --- runtest/morello_transitional | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/runtest/morello_transitional b/runtest/morello_transitional index d851948..8632615 100644 --- a/runtest/morello_transitional +++ b/runtest/morello_transitional @@ -328,7 +328,10 @@ setgid02 setgid02 setgid03 setgid03
setpgid01 setpgid01 -setpgid02 setpgid02 +# This test has been updated upstream and makes incorrect assumptions breaking +# CI. Skip it for Morello release 1.6.0, but should be run again once a fix is +# decided with upstream. +#setpgid02 setpgid02 setpgid03 setpgid03
setregid01 setregid01
+1
On 11/04/2023 13:57, Teo Couprie Diaz wrote:
setpgid02 was changed upstream in commit f2797fa44893 ("setpgid02: Convert to new LTP API") and now assumes that LTP runs in a different session from init (PID 1). This breaks in our CI as the busybox rootfs runs sh as PID 1.
Don't run this test in CI for the morello release 1.6.0 while waiting for a fix to be decided with upstream.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
runtest/morello_transitional | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/runtest/morello_transitional b/runtest/morello_transitional index d851948..8632615 100644 --- a/runtest/morello_transitional +++ b/runtest/morello_transitional @@ -328,7 +328,10 @@ setgid02 setgid02 setgid03 setgid03 setpgid01 setpgid01 -setpgid02 setpgid02 +# This test has been updated upstream and makes incorrect assumptions breaking +# CI. Skip it for Morello release 1.6.0, but should be run again once a fix is +# decided with upstream. +#setpgid02 setpgid02 setpgid03 setpgid03 setregid01 setregid01
On 11-04-2023 13:57, Teo Couprie Diaz wrote:
setpgid02 was changed upstream in commit f2797fa44893 ("setpgid02: Convert to new LTP API") and now assumes that LTP runs in a different session from init (PID 1). This breaks in our CI as the busybox rootfs runs sh as PID 1.
Don't run this test in CI for the morello release 1.6.0 while waiting for a fix to be decided with upstream.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
LGTM
runtest/morello_transitional | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/runtest/morello_transitional b/runtest/morello_transitional index d851948..8632615 100644 --- a/runtest/morello_transitional +++ b/runtest/morello_transitional @@ -328,7 +328,10 @@ setgid02 setgid02 setgid03 setgid03 setpgid01 setpgid01 -setpgid02 setpgid02 +# This test has been updated upstream and makes incorrect assumptions breaking +# CI. Skip it for Morello release 1.6.0, but should be run again once a fix is +# decided with upstream. +#setpgid02 setpgid02 setpgid03 setpgid03 setregid01 setregid01
On 11/04/2023 14:57, Teo Couprie Diaz wrote:
setpgid02 was changed upstream in commit f2797fa44893 ("setpgid02: Convert to new LTP API") and now assumes that LTP runs in a different session from init (PID 1). This breaks in our CI as the busybox rootfs runs sh as PID 1.
Don't run this test in CI for the morello release 1.6.0 while waiting for a fix to be decided with upstream.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
runtest/morello_transitional | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/runtest/morello_transitional b/runtest/morello_transitional index d851948..8632615 100644 --- a/runtest/morello_transitional +++ b/runtest/morello_transitional @@ -328,7 +328,10 @@ setgid02 setgid02 setgid03 setgid03 setpgid01 setpgid01 -setpgid02 setpgid02 +# This test has been updated upstream and makes incorrect assumptions breaking +# CI. Skip it for Morello release 1.6.0, but should be run again once a fix is +# decided with upstream. +#setpgid02 setpgid02 setpgid03 setpgid03 setregid01 setregid01
Ship it!
Kevin
Thanks for the reviews everyone, Now superseded by [PATCH] syscalls/setpgid02: Disable EPERM test case Link: https://op-lists.linaro.org/archives/list/linux-morello-ltp@op-lists.linaro....
On 11/04/2023 13:57, Teo Couprie Diaz wrote:
setpgid02 was changed upstream in commit f2797fa44893 ("setpgid02: Convert to new LTP API") and now assumes that LTP runs in a different session from init (PID 1). This breaks in our CI as the busybox rootfs runs sh as PID 1.
Don't run this test in CI for the morello release 1.6.0 while waiting for a fix to be decided with upstream.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
runtest/morello_transitional | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/runtest/morello_transitional b/runtest/morello_transitional index d851948..8632615 100644 --- a/runtest/morello_transitional +++ b/runtest/morello_transitional @@ -328,7 +328,10 @@ setgid02 setgid02 setgid03 setgid03 setpgid01 setpgid01 -setpgid02 setpgid02 +# This test has been updated upstream and makes incorrect assumptions breaking +# CI. Skip it for Morello release 1.6.0, but should be run again once a fix is +# decided with upstream. +#setpgid02 setpgid02 setpgid03 setpgid03 setregid01 setregid01
linux-morello-ltp@op-lists.linaro.org
-
Kevin Brodsky -
Teo Couprie Diaz -
Tudor Cretu -
Zachary Leaf