On Tue, May 02, 2023 at 03:43:40PM +0100, Teo Couprie Diaz wrote:
Hi Beata,
On 02/05/2023 15:01, Beata Michalska wrote:
On Wed, Apr 26, 2023 at 05:18:59PM +0200, Kevin Brodsky wrote:
On 26/04/2023 14:30, Teo Couprie Diaz wrote:
Commit 41348659371e ("setpgid02: Temporarily disable EPERM test case") disabled a test case that failed in CI due to its configuration.
This temporary measure is now suprseded by the fixes upstream. Revert this commit and cherry-pick the relevant upstream commits.
These commits will be in the upcoming (in a few weeks) LTP release, so it might not be needed to cherry-pick them now.
Teo Couprie Diaz (3): Revert "setpgid02: Temporarily disable EPERM test case" setpgid02: Use pid_max as PGID for EPERM setpgid03: Add test for PGID in different session
testcases/kernel/syscalls/setpgid/setpgid02.c | 19 +++++++------------ testcases/kernel/syscalls/setpgid/setpgid03.c | 4 ++++ 2 files changed, 11 insertions(+), 12 deletions(-)
I think it makes sense to get this series in. It will avoid a conflict next time we merge upstream LTP.
Indeed, though it would be good to:
- potentially align the revert commit to how it has been handled so far (e.g.: https://git.morello-project.org/morello/morello-linux-ltp/-/commit/ca598855 )
- for the cherry-picks it would be good to mark them as such: (e.g. git cherry-pick -xs .... )
Thanks for the comments, I agree this would be much better. Sorry for sending it out without looking better into how it should be done!
I can amend the patches if you are ok with it.
I'm ok for you to do it if you prefer, thanks in advance.
Landed on next. (I have added your sing-off for revert commit - shout if you want it to be removed)
--- BR B.
Best regards Téo
BR B.
Kevin _______________________________________________ linux-morello-ltp mailing list -- linux-morello-ltp@op-lists.linaro.org To unsubscribe send an email to linux-morello-ltp-leave@op-lists.linaro.org
linux-morello-ltp mailing list -- linux-morello-ltp@op-lists.linaro.org To unsubscribe send an email to linux-morello-ltp-leave@op-lists.linaro.org