Hi,
On 9/23/22 15:06, Beata Michalska wrote:
Hi Amit,
On Mon, Sep 19, 2022 at 04:12:02PM +0530, Amit Daniel Kachhap wrote:
Enable struct siginfo and sigevent related signal tests in the extended PCuABI syscall list.
Signed-off-by: Amit Daniel Kachhap amit.kachhap@arm.com
Changes in v2: none
runtest/morello_transitional_extended | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)
diff --git a/runtest/morello_transitional_extended b/runtest/morello_transitional_extended index a823fe62a..e75078a8b 100644 --- a/runtest/morello_transitional_extended +++ b/runtest/morello_transitional_extended @@ -34,3 +34,26 @@ semop03 semop03 shmat01 shmat01 shmat02 shmat02 shmat03 shmat03
+timer_create01 timer_create01 +timer_create02 timer_create02 +timer_create03 timer_create03 +timer_delete01 timer_delete01 +timer_delete02 timer_delete02
I haven't looked at the details but not all timer* testcases have been enabled here - any reason for that ?
I added as I tested these in kselftests. But yes I agree that the few remaining can be added here for completeness.
+mq_open01 mq_open01 +mq_notify01 mq_notify01 +mq_notify02 mq_notify02 +mq_timedsend01 mq_timedsend01 +mq_timedreceive01 mq_timedreceive01 +mq_unlink01 mq_unlink01
+rt_sigqueueinfo01 rt_sigqueueinfo01 +rt_tgsigqueueinfo01 rt_tgsigqueueinfo01
Same here for rt_sigtimedwait
+pidfd_open01 pidfd_open01 +pidfd_open02 pidfd_open02 +pidfd_open03 pidfd_open03 +pidfd_open04 pidfd_open04
It seems that only pidfd_open04 is relying on signals. It makes sense to tun the others to make sure pidfd_open works as expected in the first place I guess.
+pidfd_send_signal01 pidfd_send_signal01 +pidfd_send_signal02 pidfd_send_signal02 +pidfd_send_signal03 pidfd_send_signal03
I do appreciate that those are somehow grouped by relevance, though it seems that the syscalls list is kept in alphabetical order (with some exceptions). I am not entirely convinced that's a rule though.
I missed seeing the alphabetical order list. I will update in the next iteration.
Thanks, Amit
BR B.
-- 2.17.1