On 13/02/2023 16:29, Beata Michalska wrote:
On Mon, Feb 06, 2023 at 05:54:31PM +0000, Teo Couprie Diaz wrote:
There is one script-based test in kernel/syscalls which is test_ioctl. It will run, but the reported status might be incorrect because of missing test framework binaries it depends on. Add the target for those dependencies to the build instructions in the README.
Apologies for being picky here but could we rephrase the commit message a bit to smth along the lines of:
No worries, the commit message could clearly be better !
Add 'tools/apicmds' to build targets to satisfy the dependency for those tests that do rely on it, namely test_ioctl, which despite being shell-based one does not follow the usual approach of using the test.sh test library, relying on apicmds binaries instead. This should be fixed at some point though.
?
I mostly agree, but it could be more explicit. What do you think of :
Add 'tools/apicmds' to build targets to satisfy the dependency for the tests that do rely on it. Namely: test_ioctl which, despite being shell-based, does not follow the usual approach of using the test.sh test library, instead relying on the legacy approach of using apicmds binaries. It should be reworked to use the new framework at some point though.
?
Happy to send a new patch separately if you wish, to be honest this shouldn't have been part of the same series anyway. Thanks for the proposed change Téo
BR B.
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
README.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/README.rst b/README.rst index 4aebadd35..8b6e3a776 100644 --- a/README.rst +++ b/README.rst @@ -97,9 +97,9 @@ Assumptions: *TRIPLE* & *MORELLO_SUPPORT* in `Building Musl`) LTP_BUILD - out-of-tree build path (created by LTP's build.sh script if needed) LTP_INSTALL - destination path where LTP tests are to be installed
- TARGETS - build targets, currently only pan and testcases/kernel/syscalls
are supported, it can be further narrowed down for specific syscalltestcases:
- TARGETS - build targets, currently only pan, tools/apicmds and
testcases/kernel/syscalls are supported, it can be further narroweddown for specific syscall testcases: TARGETS="pan testcases/kernel/syscalls/${syscall}" TARGET_FEATURE - morello+c64 (purecap) only: -march=morello+c64@@ -117,7 +117,7 @@ Assumptions: export CONFIGURE_OPT_EXTRA="--prefix=/ --host=aarch64-linux-gnu --disable-metadata --without-numa" MAKE_OPTS="TST_NEWER_64_SYSCALL=no TST_COMPAT_16_SYSCALL=no" \
- TARGETS="pan testcases/kernel/syscalls" BUILD_DIR="$LTP_BUILD" \
- TARGETS="pan tools/apicmds testcases/kernel/syscalls" BUILD_DIR="$LTP_BUILD" \ CFLAGS="$CFLAGS" LDFLAGS="$LDFLAGS" \ ./build.sh -t cross -o out -ip "${LTP_INSTALL}"
2.25.1
linux-morello-ltp mailing list -- linux-morello-ltp@op-lists.linaro.org To unsubscribe send an email to linux-morello-ltp-leave@op-lists.linaro.org