Hey guys,
I tried to start the vhost-device-rng daemon with QEMU v8.1.0 when I noticed that upon startup QEMU crashes [1]. The last known good version is v7.2.0. A bisect session between the two tags yielded this commit [2]. In that patch the hunk that starts at line 1176 adds a call to virtio_pci_set_guest_notifier() with a second parameter of VIRTIO_CONFIG_IRQ_IDX, which is -1. That call trickles down to function vhost_user_get_vq_index() [3] where the assert is generated. I am guessing that all the pci based vhost-devices would be affected by this change, hence this email. Has anyone seen this when using a version of QEMU that is higher than v7.2.0?
To reproduce, start the vhost-device-rng with:
$ ./vhost-device-rng --socket-path=$(PATH_TO_SOCKET)/rng.sock -c 1 -m 512 -p 1000
And in another shell start qemu v8.1.0 with something that looks like this[4], with line 7 to 10 being the most important. Here I'm using RNG but I suppose any of the vhost-devices would be affected by this.
I'll wait to hear back from you guys before I make a fool of myself on the QEMU failing list.
Thanks, Mathieu
[1]. https://pastebin.linaro.org/view/4d39b814 [2]. 1680542862ed virtio-pci: add support for configure interrupt [3]. https://github.com/qemu/qemu/blob/v8.0.0/hw/virtio/vhost-user.c#L2152 [4]. https://pastebin.linaro.org/view/a15db9b0
On 20-10-23, 16:48, Mathieu Poirier wrote:
Hey guys,
I tried to start the vhost-device-rng daemon with QEMU v8.1.0 when I noticed that upon startup QEMU crashes [1]. The last known good version is v7.2.0. A bisect session between the two tags yielded this commit [2]. In that patch the hunk that starts at line 1176 adds a call to virtio_pci_set_guest_notifier() with a second parameter of VIRTIO_CONFIG_IRQ_IDX, which is -1. That call trickles down to function vhost_user_get_vq_index() [3] where the assert is generated. I am guessing that all the pci based vhost-devices would be affected by this change, hence this email. Has anyone seen this when using a version of QEMU that is higher than v7.2.0?
To reproduce, start the vhost-device-rng with:
$ ./vhost-device-rng --socket-path=$(PATH_TO_SOCKET)/rng.sock -c 1 -m 512 -p 1000
And in another shell start qemu v8.1.0 with something that looks like this[4], with line 7 to 10 being the most important. Here I'm using RNG but I suppose any of the vhost-devices would be affected by this.
I'll wait to hear back from you guys before I make a fool of myself on the QEMU failing list.
This reminds of the fix I added long back, just in case it helps you:
commit 91208dd297f2 ("virtio: i2c: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX")
On Tue, 24 Oct 2023 at 21:44, Viresh Kumar viresh.kumar@linaro.org wrote:
On 20-10-23, 16:48, Mathieu Poirier wrote:
Hey guys,
I tried to start the vhost-device-rng daemon with QEMU v8.1.0 when I noticed that upon startup QEMU crashes [1]. The last known good version is v7.2.0. A bisect session between the two tags yielded this commit [2]. In that patch the hunk that starts at line 1176 adds a call to virtio_pci_set_guest_notifier() with a second parameter of VIRTIO_CONFIG_IRQ_IDX, which is -1. That call trickles down to function vhost_user_get_vq_index() [3] where the assert is generated. I am guessing that all the pci based vhost-devices would be affected by this change, hence this email. Has anyone seen this when using a version of QEMU that is higher than v7.2.0?
To reproduce, start the vhost-device-rng with:
$ ./vhost-device-rng --socket-path=$(PATH_TO_SOCKET)/rng.sock -c 1 -m 512 -p 1000
And in another shell start qemu v8.1.0 with something that looks like this[4], with line 7 to 10 being the most important. Here I'm using RNG but I suppose any of the vhost-devices would be affected by this.
I'll wait to hear back from you guys before I make a fool of myself on the QEMU failing list.
This reminds of the fix I added long back, just in case it helps you:
commit 91208dd297f2 ("virtio: i2c: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX")
Thanks - that's exactly the fix I needed - I sent a patch to the mailing list and cc'ed you.
-- viresh
stratos-dev@op-lists.linaro.org
-
Mathieu Poirier -
Viresh Kumar