Re: [Stratos-dev] [PATCH V7 0/2] virtio: Add specification for virtio-gpio

On Wed, Jul 28, 2021 at 1:11 PM Viresh Kumar viresh.kumar@linaro.org wrote:

Version history of the specification I sent:

V6 -> V7:

• Drop Activate/Deactivate requests and merge them with set-direction one.
• Dropped separate calls to set direction to input or output (with a value), with a single call to set-direction (input, output, or none). Note that the driver needs to call set-value before calling set-direction-out now.
• Allow multiple messages for a GPIO line to be sent together, they must be processed in order though.
• The gpio-line names aren't required to be set for all the lines now, it is optional and can be present only for a subset of lines. Provided example as well.
• Merge irq-set/mask/unmask to a single set-irq-type message.
• We have only 6 message types now instead of 11 in v6.
• Mentioned about non-atomic nature of the these messages in commit log for patch 1/2.
• Improved spec content overall.

Nice update, this all sounds good to me. I'll go through the two patches in more detail next, but don't expect to find much then.

Arnd