14 Oct
2022
14 Oct
'22
10:45 p.m.
On Thu, Oct 13, 2022 at 8:12 AM Viresh Kumar viresh.kumar@linaro.org wrote:
On 11-10-22, 09:46, Viresh Kumar wrote:
What about the below code changes on top of V6 ?
Changes:
- Removed BufferInternal.
- Event contains a reference to the Buffer now, with lifetime.
- read_edge_event() expects a mutable reference to buffer, to make it exclusive, i.e. disallow any previous Event references to exist at compilation itself.
Bartosz, should I send a V7 now with these changes ? I hope everything is settled ?
Maybe also add chained mutators everywhere? To be able to do settings.set_direction().set_edge() etc.?
And I would still love a thorough API review from someone who actually knows rust too. :(
But I will play some more with v7 so do send it.
Bartosz