Hello,
I submitted https://lore.kernel.org/all/CAKycSdDMxfto6oTqt06TbJxXY=S7p_gtEXWDQv8mz0d9zt3... and my attention was drawn here and have a few comments.
Firstly, I was wondering why you didn't create a separate *-sys crate for these bindings? see https://doc.rust-lang.org/cargo/reference/build-scripts.html#-sys-packages for more information.
Secondly, I noticed when developing my aforementioned, patch that `bindgen` adds quite a few dependencies that probably aren't needed by the average consumer of this crate. So I was wondering what are your thoughts about generating and committing a bindings.rs then optionally using these dependencies via a feature flag?
Lastly, With your `make` integration, it looks like we could also remove the `cc` dependency by allowing `make` to build libgpiod instead and just linking with that, instead of compiling libgpiod twice.
Kind regards,
Gerard.