On 2021/10/12 22:09, Arnd Bergmann wrote:
@@ -124,13 +140,23 @@ \subsubsection{Device Operation: Operation Status}\label{sec:Device Types / I2C
\drivernormative{\subsubsection}{Device Operation}{Device Types / I2C Adapter Device / Device Operation}
+A driver SHOULD implement the VIRTIO_I2C_F_ZERO_LENGTH_REQUEST feature.
I don't think this needs to be "SHOULD", as a driver may be written to only talk to certain i2c clients on the device side, and they do not need zero length requests. Maybe this could be
"A driver MAY assume that the VIRTIO_I2C_F_ZERO_LENGTH_REQUEST feature is available".
Agree. "MAY" is better.