[Stratos-dev] Re: [PATCH V4 1/4] xen: Make struct privcmd_irqfd's layout architecture independent

On 16.10.23 09:11, Viresh Kumar wrote:

Using indirect pointers in an ioctl command argument means that the layout is architecture specific, in particular we can't use the same one from 32-bit compat tasks. The general recommendation is to have __u64 members and use u64_to_user_ptr() to access it from the kernel if we are unable to avoid the pointers altogether.

Fixes: f8941e6c4c71 ("xen: privcmd: Add support for irqfd") Reported-by: Arnd Bergmann arnd@kernel.org Closes: https://lore.kernel.org/all/268a2031-63b8-4c7d-b1e5-8ab83ca80b4a@app.fastmai... Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

Reviewed-by: Juergen Gross jgross@suse.com

Juergen